bump NDK to latest LTS or 25 #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
reviewed
Aug 4, 2022
| @@ -26,7 +26,7 @@ ENV DEBIAN_FRONTEND=noninteractive | |||
| ARG SDK_VERSION=commandlinetools-linux-8512546_latest.zip | |||
| ARG ANDROID_BUILD_VERSION=31 | |||
| ARG ANDROID_TOOLS_VERSION=31.0.0 | |||
| ARG NDK_VERSION=21.4.7075529 | |||
| ARG NDK_VERSION=25.0.8775105 | |||
There was a problem hiding this comment.
This should be aligned with a change on React Native's end (especially the template)
There was a problem hiding this comment.
CI also looks failed:
/opt/android/ndk/25.0.8775105/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64 doesn't exist.
There was a problem hiding this comment.
it'll just be updating android/build.gradle right
NDK 25 been looking pretty solid for me past few months
think only extra thing had to do was bump CMake from 3.22.1 -> 3.23.1 on Ubuntu 20.04
There was a problem hiding this comment.
Yup I think we should be fine by updating everything to NDK 25 for RN 0.71
There was a problem hiding this comment.
Thanks for the comments. I'll try to finish the PR very soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.