Skip to content
This repository has been archived by the owner on Jun 16, 2023. It is now read-only.

improve basic example #2736

Closed
fabOnReact opened this issue Mar 10, 2020 · 3 comments · May be fixed by #2775
Closed

improve basic example #2736

fabOnReact opened this issue Mar 10, 2020 · 3 comments · May be fixed by #2775
Assignees

Comments

@fabOnReact
Copy link
Contributor

fabOnReact commented Mar 10, 2020

Feature-Request

Describe the Feature

I would like to assign this task to myself and upgrade the Basic Example to reactnative@0.61.5 for the following reasons:

  1. The basic demo example is the main tool used to develop and test features for the react-native-camera library
  2. The basic demo example is also used in Continuos Integration to run test on the device
  3. Make the demo easier to install

Possible Implementations

  1. Fix RunTime error when recording
  2. Upgrade to react native 0.61.5 (solve bug)
  3. Add permissions
  4. Update dependencies
  5. Review the metro.config.js and rn-cli.config.js configurations
@fabOnReact
Copy link
Contributor Author

fabOnReact commented Mar 13, 2020

Experienced on the master branch and while working on pull 2724

@fabOnReact fabOnReact changed the title upgrade basic example to ReactNative 0.61.5 improve basic example Mar 13, 2020
@fabOnReact fabOnReact self-assigned this Mar 13, 2020
@MateusAndrade
Copy link
Collaborator

Experienced on the master branch and while working on pull 2724

Probably because of something between 3.9.0...master. Did you got any progress on that?

@fabOnReact
Copy link
Contributor Author

fabOnReact commented Mar 14, 2020

@MateusAndrade I was working on upgrading the example app to rn0.61.5 but I'm postponing it.

https://facebook.github.io/metro/docs/configuration/
https://callstack.com/blog/adding-an-example-app-to-your-react-native-library/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants