feat: allow camera scene when audio permissions are denied #2048

n1ru4l · 2019-01-11T09:00:08Z

Furthermore I think we should differentiate between the both cases:

Camera allowed and Audio not allowed

Camera allowed and Audio allowed

In the first case the camera view is still functional and the developer should decide whether the app user is forced to also allow audio permissions or is allowed to record without video.

What this PR does:

Prevent the camera view from not being rendered if camera permissions are granted but audio permissions are not granted.
Prevent crashes when trying to record audio without audio permissions being granted.
Show meanigful warnings for users that forgot to add permissions to Info.plist/AndroidManifest.xml

How to test this?

yarn add react-native-camera@https://github.com/n1ru4l/react-native-camera.git#d77c9c3caddf6ff0e900b1c9e70e3fd7d550e9e5

TODO:

Check if keys where defined in Info.plist before calling iOS API's (Front camera shows black screen and crashes app on iOS #1956 (comment))
Check if permissions are defined in AndroidManifest.xml before asking (possible crash)
Add documentation for new FaCC property recordAudioPermissionStatus

Affected Issues:

Closes #2051
Closes #2047

src/RNCamera.js

HighSoftWare96 · 2019-01-15T09:28:07Z

I've tested this PR. If I set the prop
captureAudio={false}
it gives me this unhandled exception:

but the camera does not work, otherwise without that the application crashes.

n1ru4l · 2019-01-15T09:39:11Z

@HighSoftWare96 What does the crashlog offer?

HighSoftWare96 · 2019-01-15T10:23:30Z

How can I retrieve the crashlog?

n1ru4l · 2019-01-15T10:26:13Z

@HighSoftWare96 check the console output in XCode

HighSoftWare96 · 2019-01-15T10:56:02Z

@n1ru4l
I'm not able to install this anymore... the packager cannot find the module "./handlePermissions", something is wrong?

n1ru4l · 2019-01-15T10:58:12Z

@HighSoftWare96 Seems like you should clear your react-native packager cache. Try starting the package with yarn react-native start --reset-cache

HighSoftWare96 · 2019-01-15T11:01:40Z

@n1ru4l Right now I'm using npm but I've already tried with npm start -- --reset-cache 🙌

ios/RN/RNCameraManager.m

sibelius

Why remove common handle permission function?

n1ru4l · 2019-01-16T09:15:21Z

@sibelius wrote

Why remove common handle permission function?

Because they now differ as the RNCamera implementation returns an object with two boolean properties instead of one boolean value

sibelius · 2019-01-16T10:28:25Z

we should remove RCTCamera soon

n1ru4l · 2019-01-17T08:53:41Z

@sibelius Do you know why on my Nexus 5X with Android 8.1.0 there is no Dialog being shown for Permissions when running the example app?

Also I do not need to add <uses-permission android:name="android.permission.CAMERA"/> to the AndroidManifest.xml (which is not in the example app anyway). However the camera view still works.

I only have to add <uses-permission android:name="android.permission.RECORD_AUDIO"/> otherwise the call in the requestPermissions function will resolve with NEVER_ASK_AGAIN. However after adding it, it will instantly resolve with GRANTED instead of showing a dialog to the user.

This happens in both development and release builds

n1ru4l · 2019-01-18T09:18:16Z

Ok I understood it partially. The AndroidManifest.xml located in react-native-camera/android/src/main/AndroidManifest.xml is "merged" with the one of the SampleApp upon building, which explains why I do not have to specify <uses-permission android:name="android.permission.CAMERA"/> in the AndroidManifest.xml of the consumer of react-native-camera.

However I still do not understand why I do not see a dialog...

n1ru4l · 2019-01-18T11:06:05Z

android/src/main/java/org/reactnative/camera/CameraModule.java

@@ -369,4 +373,22 @@ public void execute(NativeViewHierarchyManager nativeViewHierarchyManager) {
            }
        });
    }
+
+    @ReactMethod
+    public void checkIfRecordAudioPermissionsAreDefined(final Promise promise) {


I added a new method similar to the one on ios to check if the key is defined in the AndroidManifest.xml before asking for the permissions.

asanz8 · 2019-01-18T11:29:20Z

@n1ru4l Tested, it solved the problem without setting captureAudio property to false. I used a physical device (Android).

luissmg · 2019-01-18T12:41:34Z

@asanz8 Thanks for testing! I will not test it then @n1ru4l

…re defined

…us option

# [1.9.0](v1.8.1...v1.9.0) (2019-01-18) ### Features * **android:** add videoBitrate option for recordAsync ([#2055](#2055)) [skip release] ([d93a6c7](d93a6c7)) * allow camera scene when audio permissions are denied ([#2048](#2048)), Fixes [#2047](#2047), Fixes [#2051](#2051) ([22533ed](22533ed))

n1ru4l · 2019-01-18T15:02:09Z

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

…ild (#2070), Fixes #2069 It seems like Apple is rejecting apps that access a Info.plist usage description that is not available. This conflicts with enhanced developer warnings I implemented in #2048. To fix that I changed the implementation to only check if the usage descriptions are available in `DEBUG` mode. I also added a note developer warnings, that the app might crash in release mode because using a feature that requires a usage description without having one provided will result in an application crash).

## [1.9.2](v1.9.1...v1.9.2) (2019-01-25) ### Bug Fixes * **ios:** only check permission descriptions availability in debug build ([#2070](#2070)), Fixes [#2069](#2069) ([3f8b795](3f8b795)), closes [#2048](#2048)

ChangeSomeCode · 2019-01-31T10:58:54Z

src/RNCamera.js

+      PermissionsAndroid.PERMISSIONS.CAMERA,
+      params,
+    );
+    hasCameraPermissions = cameraPermissionResult === PermissionsAndroid.RESULTS.GRANTED;


Hello! Why you use different "requestPermissions" method for Camera.js and RNCamera.js? Can you add || cameraPermissionResult === true like in Camera.js? Because react-native return boolean-type result for devices before Android 6.0

thx!

# [1.9.0](react-native-camera/react-native-camera@v1.8.1...v1.9.0) (2019-01-18) ### Features * **android:** add videoBitrate option for recordAsync ([#2055](react-native-camera/react-native-camera#2055)) [skip release] ([d93a6c7](react-native-camera/react-native-camera@d93a6c7)) * allow camera scene when audio permissions are denied ([#2048](react-native-camera/react-native-camera#2048)), Fixes [#2047](react-native-camera/react-native-camera#2047), Fixes [#2051](react-native-camera/react-native-camera#2051) ([22533ed](react-native-camera/react-native-camera@22533ed))

## [1.9.2](react-native-camera/react-native-camera@v1.9.1...v1.9.2) (2019-01-25) ### Bug Fixes * **ios:** only check permission descriptions availability in debug build ([#2070](react-native-camera/react-native-camera#2070)), Fixes [#2069](react-native-camera/react-native-camera#2069) ([3f8b795](react-native-camera/react-native-camera@3f8b795)), closes [#2048](react-native-camera/react-native-camera#2048)

n1ru4l mentioned this pull request Jan 11, 2019

Black screen at first render and null object reference on android #2047

Closed

n1ru4l changed the title ~~feat: allow recording when audio permissions are denied~~ feat: allow camera scene when audio permissions are denied Jan 11, 2019

n1ru4l added Enhancement Review: feature core labels Jan 11, 2019

n1ru4l changed the title ~~feat: allow camera scene when audio permissions are denied~~ [WIP] feat: allow camera scene when audio permissions are denied Jan 11, 2019

n1ru4l mentioned this pull request Jan 11, 2019

Android Camera using Navigator No Preview(white screen) #512

Closed

n1ru4l commented Jan 14, 2019

View reviewed changes

src/RNCamera.js Outdated Show resolved Hide resolved

This was referenced Jan 15, 2019

RNCamera **will** crash on iOS if all three Privacy keys are not included in Info.plist #2051

Closed

Update RNCamera.md with NOT_AUTHORIZED problem solve #2052

Closed

"camera not authorized" in version 1.8.0 (Android) #2041

Closed

n1ru4l commented Jan 16, 2019

View reviewed changes

ios/RN/RNCameraManager.m Show resolved Hide resolved

sibelius reviewed Jan 16, 2019

View reviewed changes

n1ru4l added Android iOS and removed Enhancement labels Jan 16, 2019

n1ru4l commented Jan 18, 2019

View reviewed changes

n1ru4l force-pushed the feature-audio-permissions branch from d77c9c3 to fb43491 Compare January 18, 2019 14:09

n1ru4l added 10 commits January 18, 2019 15:50

feat: allow recording when audio permissions are denied

157ae8a

feat: ask for ios record audio permissions

62d84e2

fix: access property from enum instead of type

f3a8416

feat: show warning if permissions are not defined in Info.plist

ad9c0ba

feat: disable console.warn in production builds

e642238

fix: check result with the right constant

0d6be18

feat: show example app data as warnings

f8b01a8

feat(android): only ask for permissions if record audio permissions a…

6f9dda8

…re defined

docs(rn-camera): add documentation for FaCC recordAudioPermissionStat…

0ce324e

…us option

refactor: remove unused import

c73cb10

n1ru4l force-pushed the feature-audio-permissions branch from dac0f92 to c73cb10 Compare January 18, 2019 14:51

n1ru4l changed the title ~~[WIP] feat: allow camera scene when audio permissions are denied~~ feat: allow camera scene when audio permissions are denied Jan 18, 2019

n1ru4l merged commit 22533ed into react-native-camera:master Jan 18, 2019

n1ru4l deleted the feature-audio-permissions branch January 18, 2019 14:58

n1ru4l added the released label Jan 18, 2019

This was referenced Jan 18, 2019

actually implement captureAudio property #2011

Closed

fix(ios): only check permission descriptions availability in debug build #2070

Merged

ChangeSomeCode reviewed Jan 31, 2019

View reviewed changes

n1ru4l mentioned this pull request Feb 1, 2019

Missing NSMicrophoneUsageDescription key (#2) #2085

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow camera scene when audio permissions are denied #2048

feat: allow camera scene when audio permissions are denied #2048

n1ru4l commented Jan 11, 2019 •

edited

Loading

HighSoftWare96 commented Jan 15, 2019

n1ru4l commented Jan 15, 2019

HighSoftWare96 commented Jan 15, 2019

n1ru4l commented Jan 15, 2019

HighSoftWare96 commented Jan 15, 2019

n1ru4l commented Jan 15, 2019 •

edited

Loading

HighSoftWare96 commented Jan 15, 2019

sibelius left a comment

n1ru4l commented Jan 16, 2019

sibelius commented Jan 16, 2019

n1ru4l commented Jan 17, 2019 •

edited

Loading

n1ru4l commented Jan 18, 2019

n1ru4l Jan 18, 2019

asanz8 commented Jan 18, 2019

luissmg commented Jan 18, 2019

n1ru4l commented Jan 18, 2019

ChangeSomeCode Jan 31, 2019

feat: allow camera scene when audio permissions are denied #2048

feat: allow camera scene when audio permissions are denied #2048

Conversation

n1ru4l commented Jan 11, 2019 • edited Loading

HighSoftWare96 commented Jan 15, 2019

n1ru4l commented Jan 15, 2019

HighSoftWare96 commented Jan 15, 2019

n1ru4l commented Jan 15, 2019

HighSoftWare96 commented Jan 15, 2019

n1ru4l commented Jan 15, 2019 • edited Loading

HighSoftWare96 commented Jan 15, 2019

sibelius left a comment

Choose a reason for hiding this comment

n1ru4l commented Jan 16, 2019

sibelius commented Jan 16, 2019

n1ru4l commented Jan 17, 2019 • edited Loading

n1ru4l commented Jan 18, 2019

n1ru4l Jan 18, 2019

Choose a reason for hiding this comment

asanz8 commented Jan 18, 2019

luissmg commented Jan 18, 2019

n1ru4l commented Jan 18, 2019

ChangeSomeCode Jan 31, 2019

Choose a reason for hiding this comment

n1ru4l commented Jan 11, 2019 •

edited

Loading

n1ru4l commented Jan 15, 2019 •

edited

Loading

n1ru4l commented Jan 17, 2019 •

edited

Loading