Skip to content
This repository has been archived by the owner. It is now read-only.

Upcoming v0.64.1 cherrypicks discussion #221

Closed
2 of 15 tasks
grabbou opened this issue Mar 12, 2021 · 35 comments
Closed
2 of 15 tasks

Upcoming v0.64.1 cherrypicks discussion #221

grabbou opened this issue Mar 12, 2021 · 35 comments

Comments

@grabbou
Copy link
Contributor

@grabbou grabbou commented Mar 12, 2021

Conversations on this thread are limited to 0.64 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.64.0 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

PRs to merge:

Ready for cherry-pick:

Issues to resolve:


Edit by @kelset to update the status of PRs/commits/issues.

@pvinis

This comment has been hidden.

@TheSavior
Copy link
Contributor

@TheSavior TheSavior commented Mar 12, 2021

@grabbou, can you help make a list of all the PRs we need to merge that were already cherry picked into 0.64?

@thymikee

This comment has been hidden.

@kelset

This comment has been hidden.

@grabbou
Copy link
Contributor Author

@grabbou grabbou commented Mar 24, 2021

@grabbou, can you help make a list of all the PRs we need to merge that were already cherry picked into 0.64?

@TheSavior, here is the list of commits I have applied on 0.64-stable that were not merged to master at that time:

@mikehardy

This comment has been hidden.

@Bardiamist

This comment has been hidden.

@Johan-dutoit

This comment has been hidden.

@mikehardy

This comment has been hidden.

@mayconline
Copy link

@mayconline mayconline commented Apr 6, 2021

i'm problem with text input , when focusing on text input, it opens the keyboard the first time, but if you close the keyboard, and try to click on the text input again, the keyboard does not open again.

exists one issue open, but not resolution yet - facebook/react-native#30746

@alexco2
Copy link

@alexco2 alexco2 commented Apr 14, 2021

Hello,
Would it be possible to cherrypick this?
facebook/react-native#30737
This is a fix that would enable support for section list for the library react-native-collapsible-tab-view.

@mikehardy
Copy link

@mikehardy mikehardy commented Apr 14, 2021

@alexco2 the commit hash is the important bit: facebook/react-native@310a6bc

@alexco2
Copy link

@alexco2 alexco2 commented Apr 14, 2021

Thank you! I'm new to this whole process :)

@mikehardy
Copy link

@mikehardy mikehardy commented Apr 18, 2021

If this is not already in the list, I think facebook/react-native#31010 (update Flipper) is important, because Flipper was not published to mavenCentral until 0.75.x and jcenter is going away meaning builds will break by default with react-native 0.64 unless it's updated (or 0.65 is released) - commit facebook/react-native@3399896

@mikehardy
Copy link

@mikehardy mikehardy commented Apr 18, 2021

This is just context but I did a deep dive on "jcenter/bintray is going away" to see if I could purge react-native-device-info module of jcenter uses - including the example app and it appears yoga's 'proguard-annotations' artifact is the key to it all. There are 3 items total

1- flipper itself (requested above)
2- flipper dependency on fbjni-android-only (fixed in flipper 0.79+, so we actually need a newer one than is even on main dev branch but wait...)
3- flipper dependency on yoga progaurd-annotations which is still published on jcenter only but tracked here and will require a still-newer flipper unless they publish old artifacts on jitpack or mavenCentral

@kelset
Copy link
Member

@kelset kelset commented Apr 19, 2021

@mikehardy good info, would you mind also mentioning those here? react-native-community/discussions-and-proposals#331

@stigi
Copy link

@stigi stigi commented Apr 19, 2021

I'd like to nominate this PR that fixes dimensions after rotation on Android and that didn't make it into 0.64.0 yet:

@kbrandwijk
Copy link

@kbrandwijk kbrandwijk commented Apr 21, 2021

I would love to see this one make its way into 0.64.1, as there really is no good workaround: facebook/react-native#30164
A (low risk?) fix to Android fontstyling of placeholder texts for secureEntry TextInput fields.

@myckhel
Copy link

@myckhel myckhel commented Apr 21, 2021

Please what are the plans for RN 0.64.1?
Could it be the version of TurboModule support?

Can't really wait to have turbomodule enabled.

@pvinis
Copy link
Member

@pvinis pvinis commented Apr 23, 2021

This seems useful, as the issue happened with 64.0. facebook/react-native#30027

@eliw00d
Copy link

@eliw00d eliw00d commented Apr 23, 2021

PRs to merge:

This PR was closed in favor of facebook/react-native@bdfe2a5. So, that should make it into 0.64.1, right? This is holding us back at the moment.

@Ashoat
Copy link

@Ashoat Ashoat commented Apr 28, 2021

Would be great to include facebook/react-native@291cc95. Without this, Hermes crashes on Android don't log the error that causes the crash, which makes debugging really difficult.

Additional context:

@kelset
Copy link
Member

@kelset kelset commented Apr 29, 2021

updated top post with the commits/issues/PRs mentioned so far. The Xcode 12.5 fix commit is still in the works so we'll have to wait for that before proceeding.

@TheSavior
Copy link
Contributor

@TheSavior TheSavior commented Apr 29, 2021

We need to get this security related fix into the next patch release for 0.64: facebook/react-native@33ef82c

I'll add it to the list in the OP.

@robertying
Copy link

@robertying robertying commented May 2, 2021

Could we have this PR facebook/react-native#31062 looked at, merged and picked? It fixes a regression issue that prevents Hermes from building on Mac Catalyst.

@kelset
Copy link
Member

@kelset kelset commented May 5, 2021

Hey folks, we did a small patch release to address the Xcode 12.5 issue plus the security fix; so now we can go back to "standard" and discuss 0.64.2 over here -> #224

@kelset kelset closed this May 5, 2021
@react-native-community react-native-community locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet