Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Groom 0.62 Changelog #176

Merged
merged 4 commits into from
Mar 24, 2020
Merged

Groom 0.62 Changelog #176

merged 4 commits into from
Mar 24, 2020

Conversation

rickhanlonii
Copy link
Contributor

Summary

This PR grooms the 0.62 changelog, removing internal items and renaming/rewording others.

@rickhanlonii
Copy link
Contributor Author

After this we still need to:

  • Add a line(s) for Flipper
  • Check all the package upgrades to make sure they say the correct version
  • Add a line for the React version we're on

@rickhanlonii
Copy link
Contributor Author

@TheSavior I also removed anything that was changing flow types. This is debatable - if we're going to include them though I think we should move them all to their own sections. If you can about flow types, you'll want to read them all in one place.

alloy
alloy approved these changes Mar 21, 2020
View reviewed changes
Copy link
Member

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff, otherwise cleaning up nicely 👌

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
motiz88
motiz88 reviewed Mar 21, 2020
View reviewed changes
CHANGELOG.md
- Remove framesToPop from bridge ([a483f802fd](https://github.com/facebook/react-native/commit/a483f802fddfd927f2baa0d95e2b4094d452cddd) by [@motiz88](https://github.com/motiz88))
- Remove TimePickerAndroid from React Native ([dbf070c51e](https://github.com/facebook/react-native/commit/dbf070c51ecd14127a8317faa75cb661697b5a6b) by [@cpojer](https://github.com/cpojer))
- Remove scrollWithoutAnimationTo from ScrollView ([c7e89909da](https://github.com/facebook/react-native/commit/c7e89909da70ac5290f9971080eb897567db3e43) by [@TheSavior](https://github.com/TheSavior))
- Remove support for `framesToPop` ([8bc02fdd52](https://github.com/facebook/react-native/commit/8bc02fdd52124d0a24d96e4a61d7688328ef1660) [cf4d45ec2b](https://github.com/facebook/react-native/commit/cf4d45ec2bcd301be7793d5840de21ec7d02275b) [a483f802fd](https://github.com/facebook/react-native/commit/a483f802fddfd927f2baa0d95e2b4094d452cddd) by [@motiz88](https://github.com/motiz88))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on the other PR. I don't think this is necessarily a breaking change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@motiz88 could it be breaking for error reporters e.g. Sentry?

Copy link

@motiz88 motiz88 Mar 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an observable change in behaviour, and if they rely on it in a very particular way, then it could conceivably require them to fix something on their end. So in that sense: Yes.

But it's more "this implementation detail changed, heads up if you've come to rely on it" which might not be the same thing as "this documented public API has gone away". Maybe I'm splitting hairs though. I also get that it's probably better to err on the side of caution.

TheSavior
TheSavior approved these changes Mar 21, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@kelset kelset mentioned this pull request Mar 23, 2020
Closed
6 tasks
jeremy-deutsch
jeremy-deutsch reviewed Mar 23, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jeremy-deutsch
Copy link
Contributor

Really good cleanup here 👍

rickhanlonii and others added 3 commits March 24, 2020 12:57
@rickhanlonii @alloy
Update CHANGELOG.md
8c04dfa 
Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>
@rickhanlonii @alloy
Apply suggestions from code review
ee10a7e 
Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>
@rickhanlonii
Add Flipper, feedback from reviews
f83dc1e
@rickhanlonii rickhanlonii merged commit 54a2320 into chore/062-changelog-new Mar 24, 2020
@rickhanlonii rickhanlonii deleted the rh-0.62-grooming branch March 24, 2020 17:09
kelset added a commit that referenced this pull request Mar 26, 2020
@kelset @alloy
@jeremy-deutsch @rickhanlonii @HelloCore @thymikee
New 0.62.0 changelog (#166)
924c19d 
* changelog for 0.62 up to rc3

* [CHANGELOG] Update after fixing commit resolving

#169

* [CHANGELOG] Update for v0.62.0-rc.4

* [CHANGELOG] Sort unknowns by author

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* small tweaks to remove a couple warnings

* a few more typos fixes

* feedback

* remove empty section

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* last feedback from Jeremy

* couple other tweaks

* better fix for it

* adding a draft for the intro

* Update CHANGELOG.md

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

* changelog: move around some misplaced commits (#174)

* add more details about CLI upgrade

* Address unknown changelog entries (#175)

* Address unknown changelog entries

* Updates from feedback

* Add andorid changes back

* Groom 0.62 Changelog (#176)

* Groom 0.62 Changelog

* Update CHANGELOG.md

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

* Add Flipper, feedback from reviews

Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>

* changelog: removed duplicates and fixed inconsistent formatting (#177)

* Update 0.62 description (#178)

* Update 0.62 description

* Apply suggestions from code review

Co-Authored-By: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

* Fix typo

Co-Authored-By: Core <aukwat@gmail.com>

* Remove a known issue

* Update CHANGELOG.md

Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>

Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
Co-authored-by: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>
Co-authored-by: Jeremy Deutsch <jeremy.deutsch@smarkets.com>
Co-authored-by: Ricky <rickhanlonii@gmail.com>
Co-authored-by: Core <aukwat@gmail.com>
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@motiz88 motiz88 motiz88 left review comments

@jeremy-deutsch jeremy-deutsch jeremy-deutsch left review comments

@alloy alloy alloy approved these changes

@TheSavior TheSavior TheSavior approved these changes

@kelset kelset Awaiting requested review from kelset

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rickhanlonii @jeremy-deutsch @alloy @TheSavior @motiz88