fix: only apply button text color fix to spinner #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
pushed a commit
that referenced
this pull request
Nov 3, 2022
## [6.5.4](v6.5.3...v6.5.4) (2022-11-03) ### Bug Fixes * only apply button text color fix to spinner ([#685](#685)) ([3b1db5f](3b1db5f))
|
🎉 This issue has been resolved in version 6.5.4 🎉 If this package helps you, consider sponsoring us! 🚀 |
jsimonassi
added a commit
to Radix-Technos/datetimepicker
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up on #680 where I overrode the button text color for all types of pickers, where the intention was to override it only for spinner pickers which suffered from button text not visible.
When someone styles their pickers from xml, that would break the styling, and this should fix it..
also closes #684
The PR also brings in some other code simplifications and improvements.
Test Plan
tested locally
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)