fix(hasNotch): Add iPhone 13 lineup to list of devices with notch #1307
Conversation
rolfb
requested review from
GantMan,
Johan-dutoit,
machour and
mikehardy
as code owners
rolfb
changed the title
|
Just out of curiosity, what is following Conventional Commits useful for? I sense a learning opportunity. |
@rolfb checkout commitizen/cz-cli |
mikehardy
changed the title
There was a problem hiding this comment.
Nice! Thanks
Conventional Commits, when followed strictly (a thing we enforce with a check here as you have found :-) ), allow you to infer the type of semantic version release (patch, feature, or breaking change) that is represented by a group of commits, which then allows you to automate releases completely when PRs are merged, via a github action that scans commit logs for conventional commits, infers the type of release and makes the correct version bump
You'll see it in action here - as soon as I merge this it'll do a patch release
## [8.3.2](v8.3.1...v8.3.2) (2021-09-15) ### Bug Fixes * **hasNotch:** Add iPhone 13 lineup to list of devices with notch ([#1307](#1307)) ([44193d5](44193d5))
|
🎉 This PR is included in version 8.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@mikehardy Appreciate the explanation, and thank you for the quick merge and release :) |
|
Hi @mikehardy && @rolfb I just found the reference here how it was for IOS 12, there i can see IOS file changes |
|
Seems like I missed a file 🥺 |
seems like that, hope you will add that file soon, eagerly waiting for testing , thanks for your efforts |
Adds missing device name by code for iPhone 13 lineup. Relates to react-native-device-info#1307
|
@hiteshSavkare can you have a look at #1309 and see if that fixes things for you? |
@rolfb yes perfect, working as expected |
@hiteshSavkare great! if you have a chance to verify that all four iPhone 13 devices are correctly mapped now I'd appreciate it 😊 I couldn't find official docs for firmware identifiers but it's highly likely that they are following the same pattern. |
* fix(hasNotch): Missing device name for iPhone 13 Adds missing device name by code for iPhone 13 lineup. Relates to #1307 Updated device code to name mapping to match the information in the sqlite3 device traits database provided with Xcode RC.
## [8.3.2](react-native-device-info/react-native-device-info@v8.3.1...v8.3.2) (2021-09-15) ### Bug Fixes * **hasNotch:** Add iPhone 13 lineup to list of devices with notch ([#1307](react-native-device-info/react-native-device-info#1307)) ([06cd2de](react-native-device-info/react-native-device-info@06cd2de))
## [8.3.3](react-native-device-info/react-native-device-info@v8.3.2...v8.3.3) (2021-09-16) ### Bug Fixes * **hasNotch:** Missing device name for iPhone 13 ([#1309](react-native-device-info/react-native-device-info#1309)) ([8cd309c](react-native-device-info/react-native-device-info@8cd309c)), closes [#1307](react-native-device-info/react-native-device-info#1307)
## [8.3.2](react-native-device-info/react-native-device-info@v8.3.1...v8.3.2) (2021-09-15) ### Bug Fixes * **hasNotch:** Add iPhone 13 lineup to list of devices with notch ([#1307](react-native-device-info/react-native-device-info#1307)) ([44193d5](react-native-device-info/react-native-device-info@44193d5))
## [8.3.3](react-native-device-info/react-native-device-info@v8.3.2...v8.3.3) (2021-09-16) ### Bug Fixes * **hasNotch:** Missing device name for iPhone 13 ([#1309](react-native-device-info/react-native-device-info#1309)) ([0bc979e](react-native-device-info/react-native-device-info@0bc979e)), closes [#1307](react-native-device-info/react-native-device-info#1307)
Description
iPhone 13 lineup is about a week out, so adding this to the device list for devices with notch.
Compatibility