fix(hasNotch): Missing device name for iPhone 13 #1309

rolfb · 2021-09-16T10:49:53Z

Description

Adds missing device name by code for iPhone 13 lineup. Relates to #1307

Compatibility

OS	Implemented
iOS	✅

Adds missing device name by code for iPhone 13 lineup. Relates to react-native-device-info#1307

schie

LGTM

hiteshSavkare · 2021-09-16T11:54:54Z

ios/RNDeviceInfo/RNDeviceInfo.m

+	@"iPhone14,1": @"iPhone 13 mini",
+        @"iPhone14,2": @"iPhone 13",
+        @"iPhone14,3": @"iPhone 13 Pro",
+        @"iPhone14,4": @"iPhone 13 Pro Max",


Hi @rolfb
for iPhone 13 the above combination is not working , whereas for other devices of 13 series its working as expected .
I tried with following combinations and looks me fine , i m not sure what is the number game of 1,2,3,4 vs 5,2,3,4.

@"iPhone14,5": @"iPhone 13 mini", @"iPhone14,2": @"iPhone 13", @"iPhone14,3": @"iPhone 13 Pro", @"iPhone14,4": @"iPhone 13 Pro Max",

Sorry i am not IOS expert , just done some experiment with this numbers , so cant say anything about this

@hiteshSavkare Great feedback, how exactly are you testing this?

@rolfb Thanks,
react-native-device-info into is integrated in my project, so changed the file RNDeviceInfo.m with above code and building the project with xcode 13 and testing on simulators of 13 series

@hiteshSavkare updated the file now, going to try to verify with the most recent xcode beta as well.

Sounds good @rolfb, thanks

@hiteshSavkare Updated the list to match the device traits list in Xcode

sqlite> select ProductType,ProductDescription from Devices where ProductDescription LIKE 'iPhone 13%'; ProductType|ProductDescription iPhone14,2|iPhone 13 Pro iPhone14,3|iPhone 13 Pro Max iPhone14,4|iPhone 13 mini iPhone14,5|iPhone 13

Great @rolfb , Hope you tested with simulators or Do i need to test again ?

@hiteshSavkare didn't check as I expect Xcode's own lookup tables to be correct. Feel free to verify as the list from Xcode isn't exactly matching the one you provided.

@rolfb looks fine 👍

rolfb · 2021-09-16T12:30:11Z

@schie @mikehardy please hold back on merging this for a little while, need to verify codes with Xcode RC

Updated device code to name mapping to match the information in the sqlite3 device traits database provided with Xcode RC.

rolfb · 2021-09-16T13:20:07Z

@schie @mikehardy please hold back on merging this for a little while, need to verify codes with Xcode RC

Ok, I think we're good. Matching the exact values provided by Xcode RC itself from Contents/Developer/Platforms/iPhoneOS.platform/usr/standalone/device_traits.db

sqlite> select ProductType,ProductDescription from Devices where ProductDescription LIKE 'iPhone 13%';
ProductType|ProductDescription
iPhone14,2|iPhone 13 Pro
iPhone14,3|iPhone 13 Pro Max
iPhone14,4|iPhone 13 mini
iPhone14,5|iPhone 13

mikehardy · 2021-09-16T15:25:19Z

Thank you all so much!

## [8.3.3](v8.3.2...v8.3.3) (2021-09-16) ### Bug Fixes * **hasNotch:** Missing device name for iPhone 13 ([#1309](#1309)) ([0bc979e](0bc979e)), closes [#1307](#1307)

rndi-bot · 2021-09-16T15:26:50Z

🎉 This PR is included in version 8.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

harisshk · 2022-02-15T10:03:32Z

iPhone 13 series hasNotch() not working giving value as false

mikehardy · 2022-02-15T12:53:45Z

@harisshk https://stackoverflow.com/help/how-to-ask / https://stackoverflow.com/help/minimal-reproducible-example - I suspect you have outdated versions. Run our example from this repo on an iphone13 device and if you can reproduce open a new issue

pckz · 2022-02-26T03:12:36Z

@harisshk same for me, tested in the simulator

schie · 2022-02-26T04:01:05Z

@pckz what version are you on?

Like @mikehardy said to @harisshk, me thinks you're on an outdate version.

pckz · 2022-02-26T04:45:23Z

@pckz what version are you on?

Like @mikehardy said to @harisshk, me thinks you're on an outdate version.

    "react-native": "0.62.2",
    "react-native-device-info": "^8.4.9",

(i've forced the latest version)

mikehardy · 2022-02-26T17:27:59Z

same for me, tested in the simulator

Tested what in the simulator? Your app? Our example? Testing our example app would be best, no telling what your app is doing, since you haven't provided any details of it

pckz · 2022-02-26T19:25:43Z

same for me, tested in the simulator

Tested what in the simulator? Your app? Our example? Testing our example app would be best, no telling what your app is doing, since you haven't provided any details of it

My project runs:

"react-native": "0.62.2",
"react-native-device-info": "^8.4.9",

About the simulator, is Phone 13 running iOS 15.2. My XCode version is 13.2.1 (13C100)

I get false value doing this:

header :

 import DeviceInfo from 'react-native-device-info';

componentWillMount:

 console.log(DeviceInfo.hasNotch());

mikehardy · 2022-02-26T22:02:06Z

Cannot reproduce with example app.

## [8.3.3](react-native-device-info/react-native-device-info@v8.3.2...v8.3.3) (2021-09-16) ### Bug Fixes * **hasNotch:** Missing device name for iPhone 13 ([#1309](react-native-device-info/react-native-device-info#1309)) ([8cd309c](react-native-device-info/react-native-device-info@8cd309c)), closes [#1307](react-native-device-info/react-native-device-info#1307)

## [8.3.3](react-native-device-info/react-native-device-info@v8.3.2...v8.3.3) (2021-09-16) ### Bug Fixes * **hasNotch:** Missing device name for iPhone 13 ([#1309](react-native-device-info/react-native-device-info#1309)) ([0bc979e](react-native-device-info/react-native-device-info@0bc979e)), closes [#1307](react-native-device-info/react-native-device-info#1307)

fix(hasNotch): Missing device name for iPhone 13

f73b6ff

Adds missing device name by code for iPhone 13 lineup. Relates to react-native-device-info#1307

rolfb requested review from GantMan, Johan-dutoit, machour and mikehardy as code owners September 16, 2021 10:49

rolfb mentioned this pull request Sep 16, 2021

fix(hasNotch): Add iPhone 13 lineup to list of devices with notch #1307

Merged

fix(hasNotch): Fix bad iPhone version in name

1dfe52f

schie approved these changes Sep 16, 2021

View reviewed changes

hiteshSavkare reviewed Sep 16, 2021

View reviewed changes

fix(hasNotch): Fix firmware id for iPhone 13 Mini

27c5b66

fix(hasNotch): Correct iPhone 13 device codes

dd41908

Updated device code to name mapping to match the information in the sqlite3 device traits database provided with Xcode RC.

mikehardy merged commit 0bc979e into react-native-device-info:master Sep 16, 2021

mikehardy mentioned this pull request Sep 16, 2021

hasNotch don't work in Iphone 13 #1310

Closed

rndi-bot pushed a commit that referenced this pull request Sep 16, 2021

chore(release): 8.3.3 [skip ci]

b937e53

## [8.3.3](v8.3.2...v8.3.3) (2021-09-16) ### Bug Fixes * **hasNotch:** Missing device name for iPhone 13 ([#1309](#1309)) ([0bc979e](0bc979e)), closes [#1307](#1307)

mikehardy linked an issue Sep 16, 2021 that may be closed by this pull request

hasNotch don't work in Iphone 13 #1310

Closed

rndi-bot added the released label Sep 16, 2021

roryf mentioned this pull request Jan 25, 2022

iPhone 13 Pro Max model / hasNotch not working #1370

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(hasNotch): Missing device name for iPhone 13 #1309

fix(hasNotch): Missing device name for iPhone 13 #1309

rolfb commented Sep 16, 2021 •

edited

Loading

schie left a comment

hiteshSavkare Sep 16, 2021 •

edited

Loading

rolfb Sep 16, 2021

hiteshSavkare Sep 16, 2021

rolfb Sep 16, 2021

hiteshSavkare Sep 16, 2021 •

edited

Loading

rolfb Sep 16, 2021

hiteshSavkare Sep 16, 2021

rolfb Sep 16, 2021

hiteshSavkare Sep 16, 2021

rolfb commented Sep 16, 2021

rolfb commented Sep 16, 2021

mikehardy commented Sep 16, 2021

rndi-bot commented Sep 16, 2021

harisshk commented Feb 15, 2022

mikehardy commented Feb 15, 2022

pckz commented Feb 26, 2022

schie commented Feb 26, 2022

pckz commented Feb 26, 2022

mikehardy commented Feb 26, 2022

pckz commented Feb 26, 2022

mikehardy commented Feb 26, 2022

fix(hasNotch): Missing device name for iPhone 13 #1309

fix(hasNotch): Missing device name for iPhone 13 #1309

Conversation

rolfb commented Sep 16, 2021 • edited Loading

Description

Compatibility

schie left a comment

Choose a reason for hiding this comment

hiteshSavkare Sep 16, 2021 • edited Loading

Choose a reason for hiding this comment

rolfb Sep 16, 2021

Choose a reason for hiding this comment

hiteshSavkare Sep 16, 2021

Choose a reason for hiding this comment

rolfb Sep 16, 2021

Choose a reason for hiding this comment

hiteshSavkare Sep 16, 2021 • edited Loading

Choose a reason for hiding this comment

rolfb Sep 16, 2021

Choose a reason for hiding this comment

hiteshSavkare Sep 16, 2021

Choose a reason for hiding this comment

rolfb Sep 16, 2021

Choose a reason for hiding this comment

hiteshSavkare Sep 16, 2021

Choose a reason for hiding this comment

rolfb commented Sep 16, 2021

rolfb commented Sep 16, 2021

mikehardy commented Sep 16, 2021

rndi-bot commented Sep 16, 2021

harisshk commented Feb 15, 2022

mikehardy commented Feb 15, 2022

pckz commented Feb 26, 2022

schie commented Feb 26, 2022

pckz commented Feb 26, 2022

mikehardy commented Feb 26, 2022

pckz commented Feb 26, 2022

mikehardy commented Feb 26, 2022

rolfb commented Sep 16, 2021 •

edited

Loading

hiteshSavkare Sep 16, 2021 •

edited

Loading

hiteshSavkare Sep 16, 2021 •

edited

Loading