-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Macos integration #1490
feat: Macos integration #1490
Conversation
* Add some macos specific code to return unknown status
* Add some macos references
add macos column in readme with checked implementation
… ones which are not
* update readme with correct values
@mikehardy I think i fixed issues with failing checks. Can someone rerun checks? |
@mikehardy Is there something blocking review of this PR ? |
Hi! Is there something that's blocking to merge this? 🙏🏼 |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mi stake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed a utomatically |
* Podfile update * Added macos scripts
# Conflicts: # README.md
@mikehardy @machour @GantMan @Johan-dutoit @schie This PR is opened too long. It's bit hard keeping it up to date with newest changes. Is there way for someone to review it, or to approve those tests? I could probably continue adding support for additional methods, but i think this is enough for start? |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mi stake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed a utomatically |
I keep dreaming I'll have time and I'm always sorry I haven't had time yet - the work has value though, undeniably |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mi stake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed a utomatically |
@mikehardy @machour @GantMan @Johan-dutoit @schie I can update PR for this again, but just wanna check with you if its going to merge any time soon? Can anyone do any review on this code, at least to know what else needed to be added? |
Ah, im not sure what else i can do here :( |
@fi-nik , I can review this weekend, or early next week. |
Description
Continued work on macos integration from
#1057 (comment)
Check List before ready for merge:
Promise<string>
Promise<number>
string
Promise<Object>
Promise<string>
Promise<string>
Promise<number>
Promise<string>
string
string
string
Promise<boolean>
Promise<string>
Promise<string>
Promise<string>
string
string
Promise<string>
Promise<string>
Promise<string>
Promise<number>
Promise<string>
Promise<number>
Promise<number>
Promise<number>
Promise<string>
Promise<string>
Promise<string>
Promise<string>
Promise<string>
Promise<string>
Promise<string>
Promise<number>
Promise<string>
Promise<string>
Promise<number>
string
Promise<string>
Promise<object>
Promise<string>
Promise<number>
string
Promise<string>
Promise<string>
Promise<string[]>
string
string
Promise<string>
Promise<string>
Promise<number>
Promise<number>
Promise<number>
Promise<string>
Promise<number>
Promise<string>
string
string
Promise<number>
Promise<boolean>
Promise<boolean>
boolean
boolean
Promise<boolean>
Promise<boolean>
Promise<boolean>
Promise<boolean>
Promise<bool>
Promise<boolean>
Promise<boolean>
Promise<bool>
Promise<boolean>
Promise<boolean>
boolean
Promise<bool>
Promise<string[]>
Promise<string[]>
Promise<string[]>
Promise<string>
Compatibility
Checklist
README.md
privateTypes.ts
,types.ts
)example/App.js
)