Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Macos integration #1490

Closed

Conversation

fi-nik
Copy link

@fi-nik fi-nik commented Dec 15, 2022

Description

Continued work on macos integration from
#1057 (comment)

Check List before ready for merge:

  • Update documentation
  • GitHub Action CI similar to Windows implementation
  • Go through each method, determine if possible for macOS & what it should return (updating table as progress is made)
Method Return Type iOS Android Windows MacOS Web
getAndroidId() Promise<string>
getApiLevel() Promise<number>
getApplicationName() string
getAvailableLocationProviders() Promise<Object>
getBaseOs() Promise<string>
getBuildId() Promise<string>
getBatteryLevel() Promise<number>
getBootloader() Promise<string>
getBrand() string
getBuildNumber() string
getBundleId() string
isCameraPresent() Promise<boolean>
getCarrier() Promise<string>
getCodename() Promise<string>
getDevice() Promise<string>
getDeviceId() string
getDeviceType() string
getDisplay() Promise<string>
getDeviceName() Promise<string>
getDeviceToken() Promise<string>
getFirstInstallTime() Promise<number>
getFingerprint() Promise<string>
getFontScale() Promise<number>
getFreeDiskStorage() Promise<number>
getFreeDiskStorageOld() Promise<number>
getHardware() Promise<string>
getHost() Promise<string>
getIpAddress() Promise<string>
getIncremental() Promise<string>
getInstallerPackageName() Promise<string>
getInstallReferrer() Promise<string>
getInstanceId() Promise<string>
getLastUpdateTime() Promise<number>
getMacAddress() Promise<string>
getManufacturer() Promise<string>
getMaxMemory() Promise<number>
getModel() string
getPhoneNumber() Promise<string>
getPowerState() Promise<object>
getProduct() Promise<string>
getPreviewSdkInt() Promise<number>
getReadableVersion() string
getSerialNumber() Promise<string>
getSecurityPatch() Promise<string>
getSystemAvailableFeatures() Promise<string[]>
getSystemName() string
getSystemVersion() string
getTags() Promise<string>
getType() Promise<string>
getTotalDiskCapacity() Promise<number>
getTotalDiskCapacityOld() Promise<number>
getTotalMemory() Promise<number>
getUniqueId() Promise<string>
getUsedMemory() Promise<number>
getUserAgent() Promise<string>
getUserAgentSync() string
getVersion() string
getBrightness() Promise<number>
hasGms() Promise<boolean>
hasHms() Promise<boolean>
hasNotch() boolean
hasDynamicIsland() boolean
hasSystemFeature() Promise<boolean>
isAirplaneMode() Promise<boolean>
isBatteryCharging() Promise<boolean>
isEmulator() Promise<boolean>
isKeyboardConnected() Promise<bool>
isLandscape() Promise<boolean>
isLocationEnabled() Promise<boolean>
isMouseConnected() Promise<bool>
isHeadphonesConnected() Promise<boolean>
isPinOrFingerprintSet() Promise<boolean>
isTablet() boolean
isTabletMode() Promise<bool>
supported32BitAbis() Promise<string[]>
supported64BitAbis() Promise<string[]>
supportedAbis() Promise<string[]>
syncUniqueId() Promise<string>

Compatibility

OS Implemented
iOS
Android
Windows
Macos

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I added the documentation in README.md
  • I updated the typings files (privateTypes.ts, types.ts)
  • I added a sample use of the API (example/App.js)

@fi-nik fi-nik mentioned this pull request Dec 15, 2022
8 tasks
@fi-nik fi-nik changed the title [WIP]: Macos integration Macos integration Dec 15, 2022
@fi-nik fi-nik changed the title Macos integration feat: Macos integration Dec 15, 2022
@fi-nik
Copy link
Author

fi-nik commented Mar 2, 2023

@mikehardy I think i fixed issues with failing checks. Can someone rerun checks?

@finik-htec
Copy link

@mikehardy Is there something blocking review of this PR ?

@cmgustavo
Copy link

Hi! Is there something that's blocking to merge this? 🙏🏼

@rndi-bot
Copy link
Collaborator

rndi-bot commented Sep 4, 2023

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mi stake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed a utomatically

@rndi-bot rndi-bot added the stale label Sep 4, 2023
@fi-nik
Copy link
Author

fi-nik commented Sep 6, 2023

@mikehardy @machour @GantMan @Johan-dutoit @schie This PR is opened too long. It's bit hard keeping it up to date with newest changes. Is there way for someone to review it, or to approve those tests? I could probably continue adding support for additional methods, but i think this is enough for start?

@rndi-bot rndi-bot removed the stale label Sep 6, 2023
@rndi-bot
Copy link
Collaborator

rndi-bot commented Nov 5, 2023

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mi stake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed a utomatically

@rndi-bot rndi-bot added the stale label Nov 5, 2023
@rndi-bot rndi-bot closed this Nov 12, 2023
@mikehardy mikehardy reopened this Nov 13, 2023
@rndi-bot rndi-bot closed this Nov 20, 2023
@mikehardy
Copy link
Collaborator

I keep dreaming I'll have time and I'm always sorry I haven't had time yet - the work has value though, undeniably

@mikehardy mikehardy reopened this Nov 20, 2023
@rndi-bot rndi-bot removed the stale label Nov 20, 2023
@rndi-bot
Copy link
Collaborator

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mi stake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed a utomatically

@rndi-bot rndi-bot added the stale label Jan 19, 2024
@rndi-bot rndi-bot closed this Jan 26, 2024
@fi-nik
Copy link
Author

fi-nik commented Jan 26, 2024

@mikehardy @machour @GantMan @Johan-dutoit @schie I can update PR for this again, but just wanna check with you if its going to merge any time soon? Can anyone do any review on this code, at least to know what else needed to be added?

@fi-nik
Copy link
Author

fi-nik commented Apr 4, 2024

Ah, im not sure what else i can do here :(

@schie
Copy link
Contributor

schie commented Apr 4, 2024

@fi-nik , I can review this weekend, or early next week.

@fi-nik
Copy link
Author

fi-nik commented Apr 4, 2024

@fi-nik , I can review this weekend, or early next week.

@schie Sure, its been long time a worked on this, i guess this is just part of work. Once this is merged i will check if there is more properties we can provide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants