Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix applicationName #295

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Fix applicationName #295

merged 2 commits into from
Jan 17, 2018

Conversation

alvarezloaiciga
Copy link
Contributor

I was getting undefined applicationInfo, this fixes it, and uses the logic that was not used before

@alvarezloaiciga alvarezloaiciga mentioned this pull request Jan 16, 2018
Merged
@lefoy
Copy link

lefoy commented Jan 17, 2018

I confirm this fixes the issue, please merge :)

@GantMan
Copy link
Contributor

GantMan commented Jan 17, 2018

Please update changelog and I will merge.

@GantMan GantMan merged commit d80e333 into react-native-device-info:master Jan 17, 2018
@lefoy
Copy link

lefoy commented Jan 17, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvarezloaiciga @lefoy @GantMan