docs(customization) remove 'the' #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #2240 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 33 33
Lines 597 597
Branches 79 79
=======================================
Hits 568 568
Misses 26 26
Partials 3 3Continue to review full report at Codecov.
|
|
Thanks, good catch 💯 |
flyingcircle
added a commit
that referenced
this pull request
Aug 12, 2020
* chore: Bump react-native-ratings Fixes #2029 * docs: Typo in customisation (#2052) * docs: Update source prop in avatar Add link to react native Image docs * feat: Remove containerBorderRadius props (#2068) BREAKING CHANGE: Removes containerBorderRadius from ButtonGroup * docs: Update README logo (#2094) * fix(Avatar): Unable to add border to avatar (#2060) Fixes #2059 * docs: Update urls for new github org * docs: Update link to good first issue * docs: Show next changes on live site Allows for doc changes made on the next branch to be showed on the live site via the versions page. * feat(Icon): Use platform Touchable (#2124) Allows using TouchableNativeFeedback on android, and TouchableHighlight on web and iOS. None of the breaking changes below break your app, but the look might change depending on the props used. BREAKING CHANGES: - No longer uses TouchableHighlight on android by default. - Default underlay color is now transparent instead of white - activeOpacity previously not set is now 0.3 Resolves #2027 * feat(Image): Add transition prop (#2131) New transition prop that can be used to disable the fade transition on the Image component and surrounding components - Avatar, ListItem, Tile. Resolves #2004 * feat(CheckBox): Improve accessibility (#2138) Adds roles and states for checkbox * docs: Point web link to Web Usage page * docs(Rating): Remove showReadOnlyText prop Was removed in v1 but never from dos * feat(Icon): Add support for FontAwesome5 (#2142) Allows using `font-awesome-5` anywhere icons are used. Also supports the brands, regular, and solid styles. Resolves #1877 #1338 * chore: Update bug request template * fix(Button): Bug where ripple would extend outline While using type=outline, the ripple would extend outside of the border set. May fix #1847 * feat(Button): Add colored ripple On android the ripple will now be colored based on title color and on outline, background color * feat: Make button more accessible * refactor: Cleanup Overlay and remove props (#2148) BREAKING CHANGE: Removes containerStyle, windowBackgroundColor, overlayBackgroundColor, borderRadius, width, and height props. Initial width and height of overlay are now `auto` before having set values. - `containerStyle` is now `backdropStyle` - `windowBackgroundColor`, can just set backgroundColor on `backdropStyle` - `overlayBackgroundColor`, can just set backgroundColor on `overlayStyle` - `borderRadius`, can just set borderRadius on `overlayStyle` - `width` , `height`, can just set width and height on `overlayStyle` * docs(Text): Add import to examples (#2150) * feat(Overlay, Tooltip): Add ModalComponent prop (#2151) Currently, react-native-web doesn't have an implementation for Modal as yet. This means that two of our components — Overlay, Tooltip don't work on web. To enable this we've added a ModalComponent prop so that devs can use third-party modal web packages that implement this. Resolves #2083 #2149 * docs: Update badges in readme to point to new repo * fix(Tooltip): Add new prop skipAndroidStatusBar for using inside RN Modal (#1875) There's no reliable way to check for the status bar that works for all cases. Instead, we decided to provide a prop that devs can use to specify explicitly how their status bar will be accounted for. * fix(test): Exclude node_modules when running Jest (#2155) * test: Ignore coverage from searchbar/__tests__ (#2160) Since Jest ignores `searchbar/__tests__/common.js` [#L74](https://github.com/react-native-elements/react-native-elements/blob/64315d6469cc34b67393e8c192d581118ed341c0/package.json#L74) we also need to ignore coverage for it as well. * test: Increase code coverage for Tooltip component (#2161) * ci(travis): Remove redundant syntaxes in yarn (#2159) * feat(Button): Don't call onPress when in loading state (#2144) Normally, a `loading = true` means there is a pending state. A button in the loading state shouldn't be pressable. Instead, check if loading is true before calling onPress. Resolves #2141 * docs(Input): Add onChangeText example (#2164) I could not find the onChangeText handler in the documentation i had to look elsewhere, I hope you will update this :) Co-Authored-By: Kyle Roach <kroach.work@gmail.com> * feat(Image): Add overflow hidden to containerStyle (#2167) Adding a border-radius to the Image component would always require you to pass overflow: hidden as well. Since this is a common use case, we should add the overflow: hidden by default. BREAKING CHANGE: Image will no longer overflow the container. If you need this behaviour then set overflow: visible on the containerStyle. * fix(ButtonGroup): Allow marginHorizontal on containerStyle (#2171) Fixes #2170 * feat(types): Allow partial on IconNode See #2177 (comment) * feat(Input): Change inputComponent to InputComponent (#2176) Follows the convention of component props start with a capital letter. Resolves #2089 * docs(Checkbox): Add Component to Title options (#2179) The title prop can be a string or a react component. However, the docs only showed it to be a string. This change updates the docs and adds a test for it. * docs(Divider): Remove trailing semi-colon in example (#2186) I copy/pasted this example and it produced an error because of the trailing semi-colon. It was saying `Invariant Violation: Text strings must be rendered within a <Text> component` because it semi-colon is text. Took me a while to figure out what was going on there. * docs(ListItem): Add TouchableHighlight props message (#2187) ListItem accepts all props from TouchableHighlight. This adds a note so users know. Fixes #2174 * ci: Fix lint * typo: getTooltipCoordinate (#2221) coordincates -> coordinates * added core contributors needed to readme * fixes Avatar when rounded is true The rounded prop doesn't work in some cases. I've fixed it by injecting a borderRadius prop to the Image component. * updates Avatar test snapshot * Trigger onLoad function after loading Image (#2269) * Fix issue #2206 * Cosmetic changes * meta: add GitHub sponsor button config (#2268) * fix(CheckBox): Allow default checkbox testID to be overwritten (#2272) * docs: Update slack join link (#2283) Fixes #2281 * docs(Rating): Update styles example (#2224) * docs(Input): Add example with password input (#2242) * docs(Customization): Grammar fix (#2240) * simple-line-icon correct website link (#2292) Need to regenerate docs. Ref #2288 * docs(contributing): Typo correction (#2316) * Changing color of Facebook icon (#2254) * Changing color of Facebook icon * Fix: Height for errorMessage prop on Input (#1801) * fix: Height for errorMessage prop on Input * Added prop renderErrorMessage Co-Authored-By: Kyle Roach <kroach.work@gmail.com> * Update anchors in Props section (#2294) * fix: add iconType to SocialIcon (#2317) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * fix: default left icon styles for input component (#2116) Not sure why the code coverage returned off on this, but there are no code changes in the commits. Soo.... shouldn't be a problem. Checked it out, and looks like a good fix. Thanks @ganes1410 * fix: Image component not applying style prop other than width, height (#2313) * passing style prop from Image component to rendered component, flattening updated styles, adding a test * docs: typographical fix (#2321) * chore: update lint-staged config (#2320) * feat: image source for avatar accessory (#2323) * feat: image source for avatar accessory Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * feat: add vertical prop to ButtonGroup (#2326) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * fix empty string checkbox title crash (#2331) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Update listitem.md (#2117) Example old, below issue fixed. `LinearGradient 'end' property should be an object with fields 'x' and 'y', Array type is deprecated.` * fix tile title font size issue (#2057) * Haruelrovix test/increase coverage for socialicon (#2334) * test: Increase code coverage for SocialIcon component * fix additional SocialIcon Tests Co-authored-by: haruelrovix <surat@havit.web.id> Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * feat: Remove deprecated accessibilityStates (#2335) Been deprecated in 0.62 so removing it here as to remove jest errors. * feat(types): Add vertical prop to ButtonGroup * feat(types): Allow accessory to pass source * docs: Typos and formatting * docs: Cut 2.0.0 release of docs * chore: Bump version * ci(travis): Fix typo stopping deployment * readd renderErrorMessage to index types * Fix: Object getting created with key `0` (#2337) * Update Header.js (#2199) Fix old-Android Image background crash. * update card image to reflect actual look (#2346) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * update contributing docs (#2347) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Fix Avatar flickering using deep comparison (#2287) Co-authored-by: flyingcircle <jeremyelijah@live.com> * add rtl fix for tooltip modal content (#2340) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Pass event in SearchBar (#2342) * Update customization.md Added documentation for TypeScript theme extension * fix: remove React.PropTypes since deprecated (#2338) * fix: remove React.PropTypes since deprecated * Update react-native-ratings to 7.2 Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * add useNativeDriver arg to animated input (#2355) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * fix tests * fix linting and docs prettify * improve PricingCard button props (#2332) * improve PricingCard button props Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Add Support for Fontisto Font (#2361) * Update getIconType.js * update the vector libraries. (#2370) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * chore: version 2.0.1 * move @types/react-native-vector-icons to dev deps * update test react-native version to 60.6 (#2378) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Fix #2374 - Use correct PropType for styles (#2375) This fixes the `PropTypes` as reported in #2374 * Fix keep getting Delete 'CR' [prettier/prettier] (#2215) * Add event to Image.onLoad prop (#2314) * Add theme key (#2303) * Update Image source props (#2379) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * chore: publish 2.0.2 * remove the beta from from antdesign link * update all test libraries * add textProps prop to Badge * fix checkbox no title spacing issue * only apply styles to icons that can accept them * fix ios raised button issue * add test id to listitem-padview * rename test id for listitem-padview * Revert "Add testID to ListItem::PadView" * fix padview testid placement (#2404) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * stop triggering LayoutAnimation without setting state when SearchBar-ios showCancel is true (#2390) * Image methods (#2407) * add static methods from RN Image to RNE * fix Image static methods Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Jose4gg feature/add button container style to buttongroup (#2415) * Add button container style to ButtonGroup * Fix for default prop * Add property to typescript declaration Co-authored-by: Jose Gomez <jose4gga@gmail.com> Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * add regular font to all android fonts (#2402) * add regular font to all android fonts * normal; not regular Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * add toggleAction to tooltip (#2406) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Status bar (#2405) * update status-bar-height to 2.5.0 * fix status bar height for android Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Have `IconObject` extend `TouchableHighlightProps` so that `HeaderIcon` can support props like `underlayColor` (#2185) * Add `underlayColor` to `HeaderIcon` type This change will let users specify an `underlayColor` while using an icon in their `Header`. As an example, when faced with a problem like in #640 we can either use an `Icon` component and pass it the `underlayColor` prop or add the `underlayColor` to the `rightComponent` `HeaderIcon` type. However, the latter is not currently supported by the type definitions. * Extend IconObject from TouchableHighlightProps * fix padding in list item for web (#2416) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * chore: version 2.0.3 * revert moving react-native-vector types to dev * chore: publish 2.0.4 * antdesign => ant-design (#2422) * antdesign => ant-design * antdesign => ant-design * Update card.md (#2450) (Docs) ListItem props in example code * chore(deps): bump lodash from 4.17.15 to 4.17.19 (#2451) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update docs to docusaurus v2 (#2455) * update docs to docusaurus v2 * fix app link; renderErrorMessage; add footer links Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * change deploy command for gh-pages * fix website plugin bug; website broken links * Fixing RN 0.63 issue where iOS onClose does not fire (#2437) Removing is iOS check to fix onClose not firing in RN 0.63 * Disabled button style fix for issue #2440 (#2449) * Call string() on disabled color styles in Button.js * Updated Button test snapshots Co-authored-by: Andrew Yochum <ayochum@truefit.io> * Fix Avatar docs for 2.0.4 * fix 2.0.4 docs * fix slide web 'not a function' issue (#2465) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Fix issue with avatar not displaying if passing containerStyle is passed within imageProps (#2444) * fix Avatar lint * Created BottomSheet component (#2325) * Created BottomSheet component * fix: item onPress in case of cancelButtonIndex * * Added Example with images * Fix: Added Scrollview * Fix: Added Max Height * Added Prop Types * Added Test Cases * Fix: onPress in undefined * Avatar rework (#2469) * move Accessory out of Avatar * update Accessory to have default size Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * add type for badge - textProps (#2470) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * release version 2.1.0 * Add missing link to Bottom Sheet component (#2472) * Add missing link to Bottom Sheet component * Update README.md * Rename Github to GitHub (#2474) * Modified versions.json to contain correct version number for 2.1.0 (#2476) * Versions.json 2.1 does not match tag 2.1.0 * Renamed 2.1 to 2.1.0 with Docusaurus * Fix for slower Android devices calculating height (#2352) * Fix for slower Android devices calculating height Rather than waiting an arbitrary time (500ms), let's wait for the screen to finish being painted, using requestAnimationFrame() * Update Tooltip.js * add thumbProps for custom thumb (#2479) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Refactor slider (#2480) * add thumbProps for custom thumb * Add allowTouchTrack to Slider * add test for allowTouchTrack * abstract out shared code Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * remove docs versions 0.x 1.0 and 1.1 (#2484) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * fix slider bug * stop creating component if string length == 0; https://github.com/rea… (#2436) * stop creating component if string length == 0; #2259 * Update snapshots for list item Co-authored-by: himanism <himanism@amazon.com> * add iconProps to icon (#2487) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Update bug_report.md * Fix searchbar type to inherit from InputProps (#2490) Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * fix issue with listItem alignItems center (#2485) * fix issue with listItem alignItems center * fix chevron alignment Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Listitem type (#2486) * fix issue with listItem alignItems center * update Touchable types to include new Pressable RN 63 * fix tests ForwardRef for tests Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> * Release 2.2.0 * revert PR #2485 Co-authored-by: Kyle Roach <kroach.work@gmail.com> Co-authored-by: Vikrant Negi <vikrantnegi007@gmail.com> Co-authored-by: Jesse Katsumata <niconico.clarinet@gmail.com> Co-authored-by: Sudeepto Dutta <sudeepto-dutta@outlook.com> Co-authored-by: Joe Duncko <JoeDuncko@users.noreply.github.com> Co-authored-by: Ruslan Baybekov <39907210+oxyii@users.noreply.github.com> Co-authored-by: Havit Rovik <surat@havit.web.id> Co-authored-by: Quoc-Anh Nguyen <quocanh96@gmail.com> Co-authored-by: xAirx <marcowurtz@hotmail.com> Co-authored-by: Conor Gilsenan <conorgil@users.noreply.github.com> Co-authored-by: Lim Ting Zhou <33824745+tingzhouu@users.noreply.github.com> Co-authored-by: Adam Ho <adam.ho.buss@gmail.com> Co-authored-by: Monte Thakkar <manthan.thakkar@gmail.com> Co-authored-by: Omid Ebrahimi <ebrahimi.omid69@gmail.com> Co-authored-by: Flavio Wuensche <f.wuensche@gmail.com> Co-authored-by: James George <jamesgeorge998001@gmail.com> Co-authored-by: Aleksander Tatarczyk <tatarczyk.aleksander@gmail.com> Co-authored-by: Baraa Bilal <mrbaraa8@gmail.com> Co-authored-by: Harry Moreno <morenoh149@gmail.com> Co-authored-by: Mohammed Salman <msal4@outlook.com> Co-authored-by: Edison Lancy D'souza <dsouzaedison11@gmail.com> Co-authored-by: Usama Liaquat <inconnent4@gmail.com> Co-authored-by: Nihal Saxena <saxenanihal95@gmail.com> Co-authored-by: Adnan Irfan <adnanshurta@gmail.com> Co-authored-by: Jeremy Hamilton <jeremy.hamilton@tekfive.com> Co-authored-by: Ganesh R <ganesramesh110@gmail.com> Co-authored-by: Brady Caspar <bradyscaspar@outlook.com> Co-authored-by: Rıdvan Altun <ridvanaltun@outlook.com> Co-authored-by: svmszcck <onurdemirtas91@gmail.com> Co-authored-by: superscore <1216181067@qq.com> Co-authored-by: Xavier Villelégier <x.villelegier@gmail.com> Co-authored-by: John Park <horaeng0.0@gmail.com> Co-authored-by: Johan du Toit <jdutoit.dev@gmail.com> Co-authored-by: Juniardy <Juniardy_Tan93@yahoo.com> Co-authored-by: Artashes <artashesano@gmail.com> Co-authored-by: Andre Rabold <andre.rabold@gmail.com> Co-authored-by: Chunlin <fangchunlin@huawei.com> Co-authored-by: Daniel Holmes <daniel@danielholmes.org> Co-authored-by: ivyhjk <ivyhjk@users.noreply.github.com> Co-authored-by: mohammad ameer <mohammadameerabdallah@gmail.com> Co-authored-by: andrewbeckman <beckman.andrew@gmail.com> Co-authored-by: Jose Gomez <jose4gga@gmail.com> Co-authored-by: Prabhav Chawla <prabhav_chawla@yahoo.co.in> Co-authored-by: Tom Xu <ycxzhkx@gmail.com> Co-authored-by: Daryl Lukas <hello@daryllukas.me> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Orthwein <dorthwein@gmail.com> Co-authored-by: Andrew Yochum <timecatalyst@gmail.com> Co-authored-by: Andrew Yochum <ayochum@truefit.io> Co-authored-by: Dan White <40389335+danwhite-ipc@users.noreply.github.com> Co-authored-by: Jakub Biesiada <biesiadajakub@icloud.com> Co-authored-by: Alex Yip <tsztoyip@gmail.com> Co-authored-by: Matt Anderson <lucid@wakeupdreamer.com.au> Co-authored-by: himanishm07 <himanishm07@gmail.com> Co-authored-by: himanism <himanism@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.