Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source prop missing in Image from Accessory.jsx #2793

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

Brechard
Copy link
Contributor

@Brechard Brechard commented Mar 3, 2021

When Accessory was moved out of Avatar having a custom image as Avatar stopped working. See the issue #2787

When Accessory was moved out of Avatar having a custom image as Avatar stopped working. See the issue react-native-elements#2787
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #2793 (63c8f76) into next (4f90e00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2793   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          47       47           
  Lines         947      947           
  Branches      367      367           
=======================================
  Hits          856      856           
  Misses         58       58           
  Partials       33       33           
Impacted Files Coverage Δ
src/avatar/Accessory.tsx 33.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f90e00...ff95c12. Read the comment docs.

@flyingcircle flyingcircle merged commit c3747d6 into react-native-elements:next Mar 4, 2021
@flyingcircle
Copy link
Collaborator

@Brechard Thanks much! I usually like to say thank you for submissions to the repo with a token $25. Feel free to contact me on the RNE slack for details if you're interested.

@Brechard
Copy link
Contributor Author

Brechard commented Mar 9, 2021

@flyingcircle Thanks for the offer! Nonetheless, it was very small PR and I think it would be better to use those 25$ with other ones :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants