add new social icons:facebook-messenger and whatsapp

[abhishekkumar08]

Two new social icons added to SocialIcons component: facebook-messenger and WhatsApp.

[abhishekkumar08]

I haven't tested the changes can you tell me @flyingcircle, how should I test these locally?

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (next@c049e00). Click here to learn what that means.
The diff coverage is 87.96%.

@@           Coverage Diff           @@
##             next    #2826   +/-   ##
=======================================
  Coverage        ?   90.20%           
=======================================
  Files           ?       47           
  Lines           ?      949           
  Branches        ?      368           
=======================================
  Hits            ?      856           
  Misses          ?       60           
  Partials        ?       33           

Impacted Files	Coverage Δ
src/config/BackgroundImage.tsx	100.00% <ø> (ø)
src/list/ListItem.tsx	73.91% <ø> (ø)
src/list/ListItemButtonGroup.tsx	66.66% <ø> (ø)
src/list/ListItemCheckBox.tsx	50.00% <ø> (ø)
src/list/ListItemChevron.tsx	0.00% <ø> (ø)
src/list/ListItemContent.tsx	100.00% <ø> (ø)
src/list/ListItemInput.tsx	66.66% <ø> (ø)
src/list/ListItemSubtitle.tsx	60.00% <ø> (ø)
src/list/ListItemTitle.tsx	80.00% <ø> (ø)
src/overlay/Overlay.tsx	100.00% <ø> (ø)
... and 37 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c049e00...2d815cb. Read the comment docs.

[flyingcircle]

I would test them using the react-native-elements-app. It's one of the other repos in our github.

[abhishekkumar08]

@flyingcircle I tested the app in a demo-react-native project. The whatsapp icon works perfectly fine but the facebook-messenger icon isnt showing up.

[flyingcircle]

@abhishekkumar08 there's no 'facebook-messenger' icon in font-awesome (you can view the icons available here: https://oblador.github.io/react-native-vector-icons/) You'd have to change the icon type to something like 'material-community' in order to see it.

[flyingcircle]

Documentation needs updated

[abhishekkumar08]

Upon checking the code #available-icon-sets https://reactnativeelements.com/docs/props/icon#available-icon-sets under the type , supported icon sets, links doesn't work correctly, updated in the commit 45732f2, I haven't added all the types as I don't have confirmation for all the types. Can you please tell me the other types which I have not added? @flyingcircle

[flyingcircle]

I think you got a little confused, just add the new items to the social media type list and remove the other items that you added. Also you shouldn't change the versioned_docs but the docs files.

[abhishekkumar08]

I think you got a little confused, just add the new items to the social media type list and remove the other items that you added. Also you shouldn't change the versioned_docs but the docs files.

Sorry for that, I went in flow and checked all the links. Edited the code as requested please have a look now. Thanks for the review.