fix(makeStyles): Fix object literal outside useMemo causing styles to change on every render #3844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We found that the return value of
makeStyles
was changing on every render, which impacts performance, and makes it impossible to use it as a dependency ofuseMemo
etc. without getting a "maximum update depth exceeded" error.This change resolves this issue by ensuring the empty object literal used when no props are given is created inside the
useMemo
.Type of change
How Has This Been Tested?
example
appChecklist
yarn docs-build-api
Additional context