Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent crash when ending session due to missing GMS #496

Merged
merged 1 commit into from Feb 15, 2024

Conversation

SufianBabri
Copy link
Contributor

In my app, when closing the screen I end the casting session with this command:

await GoogleCast.sessionManager.endCurrentSession(true);

This works fine generally but if the device doesn't have Google Mobile Services installed, it causes a crash with this message:

com.google.android.gms.cast.framework.zzat: com.google.android.gms.dynamite.DynamiteModule$LoadingException: No acceptable module com.google.android.gms.cast.framework.dynamite found. Local version is 0 and remote version is 0.

This PR resolves this crash.

@petrbela petrbela merged commit 882f947 into react-native-google-cast:main Feb 15, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants