Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated README.md - SIGN_IN_REQUIRED error code on Android #670

Merged
merged 2 commits into from
May 21, 2019
Merged

Updated README.md - SIGN_IN_REQUIRED error code on Android #670

merged 2 commits into from
May 21, 2019

Conversation

sregg
Copy link
Contributor

@sregg sregg commented May 21, 2019 •
edited
Loading

Summary

  • Added new Troubleshooting section at the end the README.md
  • Added SIGN_IN_REQUIRED error explanation on Android in the new Troubleshooting section.

@sregg
Updated README.md
6f601ac 
Added SIGN_IN_REQUIRED error explanation on Android.
@sregg sregg changed the title Updated README.md Updated README.md - SIGN_IN_REQUIRED error code on Android May 21, 2019
vonovak
vonovak requested changes May 21, 2019
View reviewed changes
Copy link
Member

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, it is much appreciated! Would you mind creating a separate "Troubleshooting" section at the bottom of the readme, where we could add more troubleshooting tips in the future and where they would all be in the same place?

@sregg
Copy link
Contributor Author

sregg commented May 21, 2019

That makes total sense. Will do!

@sregg
Copy link
Contributor Author

sregg commented May 21, 2019

@vonovak done ✅

@vonovak vonovak merged commit d00b7c9 into react-native-google-signin:master May 21, 2019
@vonovak
Copy link
Member

vonovak commented May 21, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonovak vonovak vonovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sregg @vonovak