Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[馃専] fileName property on Response object for iOS videos #1670

Closed
yerevin opened this issue Apr 20, 2021 · 4 comments 路 Fixed by #1880
Closed

[馃専] fileName property on Response object for iOS videos #1670

yerevin opened this issue Apr 20, 2021 · 4 comments 路 Fixed by #1880
Labels
馃悰 Bug Help Wanted :octocat: iOS Platform: iOS released 馃専 Feature Request Issue describes a feature request.
Projects
Roadmap

Comments

@yerevin
Copy link

yerevin commented Apr 20, 2021 •
edited
Loading

Description

fileName property is available only for Android photos/videos and photos in iOS, on iOS video fileName is undefined, so it would be cool to add it also for iOS videos.

Proposed Solution

Return fileName property with proper value on iOS video response object from onVideoObtained method
https://github.com/react-native-image-picker/react-native-image-picker/blob/main/ios/ImagePickerManager.m#L151
self.response[@"fileName"] = fileName;

Test Solution

Check if fileName property returned from launchCamera and launchImageLibrary (type: 'video') on iOS device has value
@yerevin yerevin added the 馃専 Feature Request Issue describes a feature request. label Apr 20, 2021
@yerevin yerevin mentioned this issue Apr 20, 2021
Closed
@ravirajn22
Copy link
Contributor

ravirajn22 commented Apr 21, 2021 •
edited
Loading

Thanks for the report. Its a bug, I will check and fix.

@Johan-dutoit Johan-dutoit added 馃悰 Bug iOS Platform: iOS labels Apr 28, 2021
@Johan-dutoit Johan-dutoit added this to To do in Roadmap Apr 29, 2021
@plgrazon
Copy link

Having this bug too, made a temporary solution by finding the last index of the forward-slash and creating a substring from there. Will there be a fix for this soon?

@dylanpyle dylanpyle mentioned this issue Sep 15, 2021
Closed
chrisbobbe added a commit to chrisbobbe/react-native-image-picker that referenced this issue Dec 3, 2021
@chrisbobbe
feat(ios): Add fileName to video assets
64a8c04 
Fixes: react-native-image-picker#1670
@chrisbobbe chrisbobbe mentioned this issue Dec 3, 2021
Merged
4 tasks
@chrisbobbe
Copy link
Contributor

I've just sent #1880.

Roadmap automation moved this from To do to Completed Dec 3, 2021
Johan-dutoit pushed a commit that referenced this issue Dec 3, 2021
@chrisbobbe
feat(ios): Add fileName to video assets (#1880)
d55c53f 
Fixes: #1670
Johan-dutoit pushed a commit that referenced this issue Dec 3, 2021
@semantic-release-bot
chore(release): 4.4.0 [skip ci]
9165103 
# [4.4.0](v4.3.0...v4.4.0) (2021-12-03)

### Features

* **ios:** Add `fileName` to video assets ([#1880](#1880)) ([d55c53f](d55c53f)), closes [#1670](#1670)
@Johan-dutoit
Copy link
Collaborator

馃帀 This issue has been resolved in version 4.4.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

MattDennyir added a commit to MattDennyir/react-native-image-picker that referenced this issue Oct 19, 2022
@MattDennyir @semantic-release-bot
chore(release): 4.4.0 [skip ci]
ddb11c6 
# [4.4.0](react-native-image-picker/react-native-image-picker@v4.3.0...v4.4.0) (2021-12-03)

### Features

* **ios:** Add `fileName` to video assets ([#1880](react-native-image-picker/react-native-image-picker#1880)) ([cbe4741](react-native-image-picker/react-native-image-picker@cbe4741)), closes [#1670](react-native-image-picker/react-native-image-picker#1670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
馃悰 Bug Help Wanted :octocat: iOS Platform: iOS released 馃専 Feature Request Issue describes a feature request.
Projects
Roadmap
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ios): Add fileName to video assets chrisbobbe/react-native-image-picker
5 participants
@Johan-dutoit @ravirajn22 @yerevin @chrisbobbe @plgrazon