feat(ios): Add fileName to video assets
#1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2021
Johan-dutoit
approved these changes
Dec 3, 2021
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thank you! |
MattDennyir
added a commit
to MattDennyir/react-native-image-picker
that referenced
this pull request
Oct 19, 2022
# [4.4.0](react-native-image-picker/react-native-image-picker@v4.3.0...v4.4.0) (2021-12-03) ### Features * **ios:** Add `fileName` to video assets ([#1880](react-native-image-picker/react-native-image-picker#1880)) ([cbe4741](react-native-image-picker/react-native-image-picker@cbe4741)), closes [#1670](react-native-image-picker/react-native-image-picker#1670)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1670
Thanks for submitting a PR! Please read these instructions carefully:
masterbranch, NOT a "stable" branch.Motivation
The file name of videos on iOS hasn't been present in their asset objects, as it has for photos. This fixes that.
Test Plan