Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change minSdkVersion for RN 0.74.1 #2302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MrRefactor
Copy link

Thanks for submitting a PR! Please read these instructions carefully:

  • Explain the motivation for making this change.
  • Provide a test plan demonstrating that the code is solid.
  • Match the code formatting of the rest of the codebase.
  • Target the main branch, NOT a "stable" branch.

Motivation (required)

React Native 0.74.1 added the minimum SDK version bump to 23. This PR tends to add the same, making sure the previous 21 is intact.

Test Plan (required)

Run example app on android.

@MrRefactor
Copy link
Author

Hey hey @brentvatne @Johan-dutoit could you please take a look at this pr?

@raduiamandi-pilot
Copy link

This is currently affecting my builds too. :(

@MrRefactor
Copy link
Author

hey hey @Johan-dutoit could you merge it?

@murilo-alvesmelo
Copy link

@Johan-dutoit merge please

@MrRefactor
Copy link
Author

Ping @brentvatne @Johan-dutoit

@BogdanRad
Copy link

@MrRefactor can you update compileSdkVersion and targetSdkVersion in 34 for this issue? thank you
image

@MrRefactor
Copy link
Author

@MrRefactor can you update compileSdkVersion and targetSdkVersion in 34 for this issue? thank you image

Please create separate PR for this, as its not a part of rn 0.74 changes

@professorkolik
Copy link

Any ETA when this will be merged?

@MrRefactor
Copy link
Author

Hey hey @brentvatne @Johan-dutoit could you please take a look at this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants