Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flurry of setNativeProps deprecation warnings when using markers #4536

Closed
sharvilak11 opened this issue Nov 25, 2022 · 8 comments
Closed

Flurry of setNativeProps deprecation warnings when using markers #4536

sharvilak11 opened this issue Nov 25, 2022 · 8 comments
Labels

Comments

@sharvilak11
Copy link
Contributor

Summary

We are updating plotted markers for drivers frequently and it gives a flurry of warnings stating - setNativeProps is deprecated and will be removed in next major release. This ultimately bloats the console outputs.

console.warn('setNativeProps is deprecated and will be removed in next major release');

Please advise how to remove this warning.

Reproducible sample code

import {Animated, Easing, Image, Platform} from 'react-native';
import {useEffect, useRef, useState} from 'react';
import {AnimatedRegion, Marker} from 'react-native-maps';
import driverMarkerImg from '../../../../../assets/driver-marker.png';

const AnimatedImage = Animated.createAnimatedComponent(Image);

function DriverMarker({location, driver, ...rest}) {
  const [marker, setMarker] = useState(null);
  const [coordinate] = useState(
    new AnimatedRegion({
      latitude: location.Latitude,
      longitude: location.Longitude,
      latitudeDelta: 0.025,
      longitudeDelta: 0.025,
    })
  );
  const rotation = useRef(new Animated.Value(0.01)).current;
  const bearingDegree = rotation.interpolate({
    inputRange: [0, 360],
    outputRange: ['0deg', '360deg'],
  });

  function animateMarker(newLocation) {
    const newCoordinate = {
      latitude: newLocation.Latitude,
      longitude: newLocation.Longitude,
      latitudeDelta: 0.025,
      longitudeDelta: 0.025,
    };
    if (newLocation.Bearing !== null) {
      Animated.timing(rotation, {
        toValue: newLocation.Bearing,
        useNativeDriver: Platform.OS !== 'android',
        easing: Easing.linear,
        duration: 250,
      }).start();
      setTimeout(() => {
        smoothNavigation();
      }, 250);
    } else {
      smoothNavigation();
    }

    function smoothNavigation() {
      coordinate.timing(newCoordinate).start();
    }
  }

  useEffect(() => {
    animateMarker(location);
  }, [location]);

  return location.Bearing ? (
    <Marker.Animated
      identifier={driver.Id}
      coordinate={coordinate}
      ref={marker => {
        setMarker(marker);
      }}
      {...rest}
    >
      <AnimatedImage source={driverMarkerImg} className="w-10 h-14" style={{resizeMode: 'contain', transform: [{rotate: bearingDegree}]}} />
    </Marker.Animated>
  ) : null;
}

export default DriverMarker;

Steps to reproduce

Re-render a marker multiple times and this warning will be printed as many times too.

Expected result

Give an option to turn off this flurry of warnings.

Actual result

image

React Native Maps Version

1.3.2

What platforms are you seeing the problem on?

Android, iOS (Apple Maps)

React Native Version

0.70.5

What version of Expo are you using?

SDK 46

Device(s)

Any device

Additional information

No response

@sharvilak11 sharvilak11 added the bug Something isn't working label Nov 25, 2022
@zhenguet
Copy link

zhenguet commented Dec 14, 2022

This is really funny.

With me, it just show on IOS, nothing on Android

@sharvilak11
Copy link
Contributor Author

sharvilak11 commented Dec 14, 2022

@zhenguet Funny thing is the console.warn statements are eating up entire memory and it starts giving memory warnings.

@zhenguet
Copy link

zhenguet commented Dec 16, 2022

@sharvilak11 yes. In my case it warns twice but I can not do anything with map -_-
it's so crazy.

@BerkeAras
Copy link

Same issue. Map still works but this warnings are spamming the console.

react-native-maps-bot pushed a commit that referenced this issue Apr 18, 2023
# [1.6.0-beta.2](v1.6.0-beta.1...v1.6.0-beta.2) (2023-04-18)

### Bug Fixes

* **marker:** remove spamming warning from MapMarker ([#4644](#4644)) ([8825312](8825312)), closes [#4536](#4536)
@react-native-maps-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.6.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@monholm monholm closed this as completed Apr 18, 2023
react-native-maps-bot pushed a commit that referenced this issue Apr 20, 2023
# [1.6.0](v1.5.0...v1.6.0) (2023-04-20)

### Bug Fixes

* **ios:** crash on Apple Maps when loading large polylines ([#4468](#4468)) ([e48e1af](e48e1af))
* **ios:** support for use_frameworks! :linkage => :static ([b0c2d42](b0c2d42))
* **marker:** remove spamming warning from MapMarker ([#4644](#4644)) ([8825312](8825312)), closes [#4536](#4536)
* **types:** missing PolygonPressEvent type export ([#4410](#4410)) ([d3557a3](d3557a3))

### Features

* enable npm provenance ([#4686](#4686)) ([3498c3f](3498c3f))
* **ios:** bump googlemaps to 7.4.0 ([#4679](#4679)) ([661cddb](661cddb))
@react-native-maps-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jijoy added a commit to Deepfleet/react-native-maps that referenced this issue Aug 31, 2023
* chore(deps): bump dev deps

* chore(android): rename android package

* chore(android): remove redundant class prefix

* chore(android): cleanup MapsPackage

* chore(android): bump compileSdkVersion and targetSdkVersion to 31

* feat(android): pin androidx.work version

Starting this november, all android apps (including updates) will require targetSdkVersion 31
and as a result compileSdkVersion 31, therefore not marking as a breaking change

* ci(pullRequest): stop linting pr titles

* chore(release): 1.4.0-beta.1 [skip ci]

# [1.4.0-beta.1](react-native-maps/react-native-maps@v1.3.2...v1.4.0-beta.1) (2022-10-10)

### Features

* **android:** pin androidx.work version ([73f21c7](react-native-maps@73f21c7))

* ci(pullRequest): stop linting pr title

* chore(deps): bump dev deps

* ci(pullRequest): check formatting

* style(prettier): fix formatting

* chore(husky): check formatting on pre-commit

* build(deps): bump @sideway/formula from 3.0.0 to 3.0.1 in /example

Bumps [@sideway/formula](https://github.com/sideway/formula) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/sideway/formula/releases)
- [Commits](hapijs/formula@v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: "@sideway/formula"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): bump dev-deps

* chore(release): 1.5.0-beta.1 [skip ci]

# [1.5.0-beta.1](react-native-maps/react-native-maps@v1.4.0...v1.5.0-beta.1) (2023-04-15)

### Features

* **android:** pin androidx.work version ([73f21c7](react-native-maps@73f21c7))

* chore(release): 1.5.0 [skip ci]

# [1.5.0](react-native-maps/react-native-maps@v1.4.0...v1.5.0) (2023-04-15)

### Features

* **android:** pin androidx.work version ([73f21c7](react-native-maps@73f21c7))

* chore(example): bump to react-native 0.70.8 (react-native-maps#4673)

* fix(types): missing PolygonPressEvent type export (react-native-maps#4410)

* chore(release): 1.5.1-beta.1 [skip ci]

## [1.5.1-beta.1](react-native-maps/react-native-maps@v1.5.0...v1.5.1-beta.1) (2023-04-16)

### Bug Fixes

* **types:** missing PolygonPressEvent type export ([react-native-maps#4410](react-native-maps#4410)) ([d3557a3](react-native-maps@d3557a3))

* fix(ios): crash on Apple Maps when loading large polylines (react-native-maps#4468)

Switch to using heap allocation to prevent corrupting the stack.

* chore(release): 1.5.1-beta.2 [skip ci]

## [1.5.1-beta.2](react-native-maps/react-native-maps@v1.5.1-beta.1...v1.5.1-beta.2) (2023-04-16)

### Bug Fixes

* **ios:** crash on Apple Maps when loading large polylines ([react-native-maps#4468](react-native-maps#4468)) ([e48e1af](react-native-maps@e48e1af))

* chore: stop updating version in package.json

Updating the version requires the Podfile.lock to update after each release.

* chore(example): use ruby bundler

* chore(example): update gemfile.lock

* test(detox): add basic setup

* chore(example): default to using patched Google-Maps-iOS-Utils

* ci: add build workflow for android and ios

* ci: rename build jobs

* ci: build ios using frameworks

* ci(stale): specify permissions

* fix(ios): support for use_frameworks! :linkage => :static

react-native-google-maps relies on headers from react-native-maps.
When using frameworks, headers from react-native-maps are no longer found, as the framework search
path for react-native-maps isn't added to the react-native-google-maps framework.

Likewise, removing the import prefix from Google-Maps-iOS-Utils resolves the imports
both with and without use_frameworks.

Note: this only brings support for `use_frameworks!` with `:linkage => :static.

* chore: rename example app

* chore(example): migrate to recommended api key setup

* ci: add placeholder google maps api key

* ci: fix xcworkspace name

* chore(release): 1.5.1-beta.3 [skip ci]

## [1.5.1-beta.3](react-native-maps/react-native-maps@v1.5.1-beta.2...v1.5.1-beta.3) (2023-04-18)

### Bug Fixes

* **ios:** support for use_frameworks! :linkage => :static ([b0c2d42](react-native-maps@b0c2d42))

* feat(ios): bump googlemaps to 7.4.0 (react-native-maps#4679)

According to the release notes, this version is functionally identical to v.7.3.0

* chore(release): 1.6.0-beta.1 [skip ci]

# [1.6.0-beta.1](react-native-maps/react-native-maps@v1.5.1-beta.3...v1.6.0-beta.1) (2023-04-18)

### Features

* **ios:** bump googlemaps to 7.4.0 ([react-native-maps#4679](react-native-maps#4679)) ([661cddb](react-native-maps@661cddb))

* fix(marker): remove spamming warning from MapMarker (react-native-maps#4644)

Resolves react-native-maps#4536

* chore(release): 1.6.0-beta.2 [skip ci]

# [1.6.0-beta.2](react-native-maps/react-native-maps@v1.6.0-beta.1...v1.6.0-beta.2) (2023-04-18)

### Bug Fixes

* **marker:** remove spamming warning from MapMarker ([react-native-maps#4644](react-native-maps#4644)) ([8825312](react-native-maps@8825312)), closes [react-native-maps#4536](react-native-maps#4536)

* ci: make reproducible exempt (react-native-maps#4681)

* feat: enable npm provenance (react-native-maps#4686)

* chore(release): 1.6.0-beta.3 [skip ci]

# [1.6.0-beta.3](react-native-maps/react-native-maps@v1.6.0-beta.2...v1.6.0-beta.3) (2023-04-20)

### Features

* enable npm provenance ([react-native-maps#4686](react-native-maps#4686)) ([3498c3f](react-native-maps@3498c3f))

* ci(push): add id-token write permissions (react-native-maps#4687)

Needed for npm provenance

* chore(release): 1.6.0-beta.3 [skip ci]

# [1.6.0-beta.3](react-native-maps/react-native-maps@v1.6.0-beta.2...v1.6.0-beta.3) (2023-04-20)

### Features

* enable npm provenance ([react-native-maps#4686](react-native-maps#4686)) ([3498c3f](react-native-maps@3498c3f))

* chore: update security policy (react-native-maps#4688)

* chore(release): 1.6.0 [skip ci]

# [1.6.0](react-native-maps/react-native-maps@v1.5.0...v1.6.0) (2023-04-20)

### Bug Fixes

* **ios:** crash on Apple Maps when loading large polylines ([react-native-maps#4468](react-native-maps#4468)) ([e48e1af](react-native-maps@e48e1af))
* **ios:** support for use_frameworks! :linkage => :static ([b0c2d42](react-native-maps@b0c2d42))
* **marker:** remove spamming warning from MapMarker ([react-native-maps#4644](react-native-maps#4644)) ([8825312](react-native-maps@8825312)), closes [react-native-maps#4536](react-native-maps#4536)
* **types:** missing PolygonPressEvent type export ([react-native-maps#4410](react-native-maps#4410)) ([d3557a3](react-native-maps@d3557a3))

### Features

* enable npm provenance ([react-native-maps#4686](react-native-maps#4686)) ([3498c3f](react-native-maps@3498c3f))
* **ios:** bump googlemaps to 7.4.0 ([react-native-maps#4679](react-native-maps#4679)) ([661cddb](react-native-maps@661cddb))

* build(android): bump gradle to 7.2

7.2 adds support for java 17 which is now the default version bundled with android studio

* docs(readme): onRegionChangeComplete called infinitely (react-native-maps#4574)

* fix(ios): followsUserLocation changes zoom level (react-native-maps#4696)

Resolves react-native-maps#4585

* chore(release): 1.6.1-beta.1 [skip ci]

## [1.6.1-beta.1](react-native-maps/react-native-maps@v1.6.0...v1.6.1-beta.1) (2023-04-21)

### Bug Fixes

* **ios:** followsUserLocation changes zoom level ([react-native-maps#4696](react-native-maps#4696)) ([3b9491e](react-native-maps@3b9491e)), closes [react-native-maps#4585](react-native-maps#4585)

* chore(react-native): bump to 0.70.9 (react-native-maps#4697)

* feat(android): bump android-maps-utils to 3.4.0 (react-native-maps#4699)

* chore(release): 1.7.0-beta.1 [skip ci]

# [1.7.0-beta.1](react-native-maps/react-native-maps@v1.6.1-beta.1...v1.7.0-beta.1) (2023-04-21)

### Features

* **android:** bump android-maps-utils to 3.4.0 ([react-native-maps#4699](react-native-maps#4699)) ([6b26c23](react-native-maps@6b26c23))

* chore(prettier): ignore ios/DerivedData (react-native-maps#4702)

* chore(release): 1.7.0 [skip ci]

# [1.7.0](react-native-maps/react-native-maps@v1.6.0...v1.7.0) (2023-04-23)

### Bug Fixes

* **ios:** followsUserLocation changes zoom level ([react-native-maps#4696](react-native-maps#4696)) ([3b9491e](react-native-maps@3b9491e)), closes [react-native-maps#4585](react-native-maps#4585)

### Features

* **android:** bump android-maps-utils to 3.4.0 ([react-native-maps#4699](react-native-maps#4699)) ([6b26c23](react-native-maps@6b26c23))

* fix(android): crash when removing feature belonging to collection (react-native-maps#4707)

Resolves react-native-maps#4706

* chore(release): 1.7.1 [skip ci]

## [1.7.1](react-native-maps/react-native-maps@v1.7.0...v1.7.1) (2023-04-23)

### Bug Fixes

* **android:** crash when removing feature belonging to collection ([react-native-maps#4707](react-native-maps#4707)) ([ae6fe90](react-native-maps@ae6fe90)), closes [react-native-maps#4706](react-native-maps#4706)

* chore: merge

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Simon-TechForm <73996878+Simon-TechForm@users.noreply.github.com>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Maxim Artyukhov <artukhov@fastmail.com>
Co-authored-by: Andrew Scherkus <ascherkus@gmail.com>
Co-authored-by: sharvilak11 <sharvilakt@gmail.com>
Co-authored-by: Bilal Abdeen <Bilal-Abdeen@users.noreply.github.com>
osk-poita121 pushed a commit to osk-poita121/react-native-maps that referenced this issue Oct 3, 2023
osk-poita121 pushed a commit to osk-poita121/react-native-maps that referenced this issue Oct 3, 2023
# [1.6.0](react-native-maps/react-native-maps@v1.5.0...v1.6.0) (2023-04-20)

### Bug Fixes

* **ios:** crash on Apple Maps when loading large polylines ([#4468](react-native-maps/react-native-maps#4468)) ([e48e1af](react-native-maps/react-native-maps@e48e1af))
* **ios:** support for use_frameworks! :linkage => :static ([b0c2d42](react-native-maps/react-native-maps@b0c2d42))
* **marker:** remove spamming warning from MapMarker ([#4644](react-native-maps/react-native-maps#4644)) ([8825312](react-native-maps/react-native-maps@8825312)), closes [#4536](react-native-maps/react-native-maps#4536)
* **types:** missing PolygonPressEvent type export ([#4410](react-native-maps/react-native-maps#4410)) ([d3557a3](react-native-maps/react-native-maps@d3557a3))

### Features

* enable npm provenance ([#4686](react-native-maps/react-native-maps#4686)) ([3498c3f](react-native-maps/react-native-maps@3498c3f))
* **ios:** bump googlemaps to 7.4.0 ([#4679](react-native-maps/react-native-maps#4679)) ([661cddb](react-native-maps/react-native-maps@661cddb))
@skizzo
Copy link

skizzo commented Nov 1, 2023

This still happens on Version 1.8.0 / iOS, please re-open this.

GoldenDragon0710 added a commit to GoldenDragon0710/google-map-react-native that referenced this issue Nov 27, 2023
GoldenDragon0710 added a commit to GoldenDragon0710/google-map-react-native that referenced this issue Nov 27, 2023
# [1.6.0](react-native-maps/react-native-maps@v1.5.0...v1.6.0) (2023-04-20)

### Bug Fixes

* **ios:** crash on Apple Maps when loading large polylines ([#4468](react-native-maps/react-native-maps#4468)) ([e48e1af](react-native-maps/react-native-maps@e48e1af))
* **ios:** support for use_frameworks! :linkage => :static ([b0c2d42](react-native-maps/react-native-maps@b0c2d42))
* **marker:** remove spamming warning from MapMarker ([#4644](react-native-maps/react-native-maps#4644)) ([8825312](react-native-maps/react-native-maps@8825312)), closes [#4536](react-native-maps/react-native-maps#4536)
* **types:** missing PolygonPressEvent type export ([#4410](react-native-maps/react-native-maps#4410)) ([d3557a3](react-native-maps/react-native-maps@d3557a3))

### Features

* enable npm provenance ([#4686](react-native-maps/react-native-maps#4686)) ([3498c3f](react-native-maps/react-native-maps@3498c3f))
* **ios:** bump googlemaps to 7.4.0 ([#4679](react-native-maps/react-native-maps#4679)) ([661cddb](react-native-maps/react-native-maps@661cddb))
@salah-ghanim salah-ghanim reopened this Dec 10, 2023
PainStaker0331 added a commit to PainStaker0331/react-native-maps that referenced this issue Mar 3, 2024
PainStaker0331 added a commit to PainStaker0331/react-native-maps that referenced this issue Mar 3, 2024
# [1.6.0](react-native-maps/react-native-maps@v1.5.0...v1.6.0) (2023-04-20)

### Bug Fixes

* **ios:** crash on Apple Maps when loading large polylines ([#4468](react-native-maps/react-native-maps#4468)) ([e48e1af](react-native-maps/react-native-maps@e48e1af))
* **ios:** support for use_frameworks! :linkage => :static ([b0c2d42](react-native-maps/react-native-maps@b0c2d42))
* **marker:** remove spamming warning from MapMarker ([#4644](react-native-maps/react-native-maps#4644)) ([8825312](react-native-maps/react-native-maps@8825312)), closes [#4536](react-native-maps/react-native-maps#4536)
* **types:** missing PolygonPressEvent type export ([#4410](react-native-maps/react-native-maps#4410)) ([d3557a3](react-native-maps/react-native-maps@d3557a3))

### Features

* enable npm provenance ([#4686](react-native-maps/react-native-maps#4686)) ([3498c3f](react-native-maps/react-native-maps@3498c3f))
* **ios:** bump googlemaps to 7.4.0 ([#4679](react-native-maps/react-native-maps#4679)) ([661cddb](react-native-maps/react-native-maps@661cddb))
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If the issue remains relevant, simply comment Still relevant and the issue will remain open. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2024
Super-CodeKing added a commit to Super-CodeKing/react_native_map that referenced this issue Apr 26, 2024
Super-CodeKing added a commit to Super-CodeKing/react_native_map that referenced this issue Apr 26, 2024
# [1.6.0](react-native-maps/react-native-maps@v1.5.0...v1.6.0) (2023-04-20)

### Bug Fixes

* **ios:** crash on Apple Maps when loading large polylines ([#4468](react-native-maps/react-native-maps#4468)) ([e48e1af](react-native-maps/react-native-maps@e48e1af))
* **ios:** support for use_frameworks! :linkage => :static ([b0c2d42](react-native-maps/react-native-maps@b0c2d42))
* **marker:** remove spamming warning from MapMarker ([#4644](react-native-maps/react-native-maps#4644)) ([8825312](react-native-maps/react-native-maps@8825312)), closes [#4536](react-native-maps/react-native-maps#4536)
* **types:** missing PolygonPressEvent type export ([#4410](react-native-maps/react-native-maps#4410)) ([d3557a3](react-native-maps/react-native-maps@d3557a3))

### Features

* enable npm provenance ([#4686](react-native-maps/react-native-maps#4686)) ([3498c3f](react-native-maps/react-native-maps@3498c3f))
* **ios:** bump googlemaps to 7.4.0 ([#4679](react-native-maps/react-native-maps#4679)) ([661cddb](react-native-maps/react-native-maps@661cddb))
fairskyDev0201 pushed a commit to fairskyDev0201/react-native-maps that referenced this issue Apr 29, 2024
fairskyDev0201 pushed a commit to fairskyDev0201/react-native-maps that referenced this issue Apr 29, 2024
# [1.6.0](react-native-maps/react-native-maps@v1.5.0...v1.6.0) (2023-04-20)

### Bug Fixes

* **ios:** crash on Apple Maps when loading large polylines ([#4468](react-native-maps/react-native-maps#4468)) ([e48e1af](react-native-maps/react-native-maps@e48e1af))
* **ios:** support for use_frameworks! :linkage => :static ([b0c2d42](react-native-maps/react-native-maps@b0c2d42))
* **marker:** remove spamming warning from MapMarker ([#4644](react-native-maps/react-native-maps#4644)) ([8825312](react-native-maps/react-native-maps@8825312)), closes [#4536](react-native-maps/react-native-maps#4536)
* **types:** missing PolygonPressEvent type export ([#4410](react-native-maps/react-native-maps#4410)) ([d3557a3](react-native-maps/react-native-maps@d3557a3))

### Features

* enable npm provenance ([#4686](react-native-maps/react-native-maps#4686)) ([3498c3f](react-native-maps/react-native-maps@3498c3f))
* **ios:** bump googlemaps to 7.4.0 ([#4679](react-native-maps/react-native-maps#4679)) ([661cddb](react-native-maps/react-native-maps@661cddb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants