fix(map): remove spamming warning from Map #4875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salah-ghanim
approved these changes
Nov 18, 2023
|
@watislaf can you please re-create another version of the pull request with both the console.log is deleted and disabling of ts-warning @ts-ignore this.marker.current?.setNativeProps(props); I will work on updating RN to higher than 0.72 which should hopefully introduce again setNativeProps as type |
|
@watislaf I'm closing this, since react-native reintroduced setNativeProps. the log is now removed from the source code as part of the update to react-native 0.73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
Yes, this is very similar to #4644
What issue is this PR fixing?
(#4536)
How did you test this PR?
locally
Before fixing on IOS this looked like this:
