Implement onUserLocationChange in AIRMap #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rborn |
|
@PTROCKI looks good, let me find a little time to test on iOS 12 and I'll come back to you ❤️ |
AurangzaibRamzan
approved these changes
Jul 1, 2019
|
@PTROCKI - found this PR while looking at heading component of user location. Was there a particular reason heading was not included? If not, I will add in subsequent PR. |
|
Can you describe, what is heading ? |
|
Sure thing. Heading or bearing, as in the compass direction. |
|
I just forgot to add it. You can create a separate PR for it. |
ssztemberg
approved these changes
Oct 10, 2019
|
I just checked that on iOS 13.1, iPhone X and it works fine. Don't forget to change readme |
|
@troZee can you please fix conflicts and I'll merge ❤️ |
|
@rborn done |
|
@troZee You should also change readme, now it mentions that this is only for Google. |
troZee
force-pushed
the
feat/mapkit-onUserLocationChange
branch
from
ae7ca53
to
1887383
Compare
yuheidapperapps
added a commit
to yuheidapperapps/react-native-maps
that referenced
this pull request
Oct 15, 2019
* master: (31 commits) Wider Note column (prevent horisontal scroll) (react-native-maps#3130) replaced deprecated bridge.imageLoader calls with moduleForClass API (react-native-maps#3125) Implement onUserLocationChange in AIRMap (react-native-maps#2889) keep current mapType when taking snapshot (react-native-maps#3120) Add mapPadding on iOS maps (react-native-maps#3119) [iOS] Expose isAccessibilityElement as a prop (react-native-maps#3115) Add supportLibVersion safeguard in gradle build (react-native-maps#3106) [0.26.1] Release rn 0.60.5 support (react-native-maps#3020) "AIRMap" was not found in the UIManager IN "0.26.0" (react-native-maps#3103) [0.26.0] Release Add Heatmap back in (react-native-maps#3064) Fixes NPE while removing already removed marker. (react-native-maps#3032) Add flat property binding on Marker for iOS (react-native-maps#3051) Add heading to the onUserLocationChange listener (react-native-maps#3045) Add onDoublePress callback (react-native-maps#2937) Allow using onPanDrag while scrollEnabled=true (react-native-maps#2935) updating pods for compile error (react-native-maps#3011) add overlay onPress event (react-native-maps#3007) Fix playServicesVersion name in installation docs (react-native-maps#3016) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(please answer here)
What issue is this PR fixing?
Resolved #2055
How did you test this PR?
Changes was made in iOS/Apple maps and tested only on ip7 iOS 11