Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rn 0.60.5 support #3020

Merged
merged 3 commits into from Oct 3, 2019
Merged

rn 0.60.5 support #3020

merged 3 commits into from Oct 3, 2019

Conversation

jgtoriginal
Copy link
Contributor

@jgtoriginal jgtoriginal commented Aug 15, 2019 •
edited

react-native 0.60.5 - package android.support.v4.content does not exist

@jgtoriginal
rn 0.60.5 support
deea6a9 
`react-native 0.60.5 - package android.support.v4.content does not exist`
@DavidPineda
Copy link

Hi @jgtoriginal, I have that same change and it generates this error.
 
#2495

Do you have the library with autolink?

@cipriancaba
Copy link

Have you tried using jetify in a postinstall in package.json? That should fix your issue and it's how older libraries are being transitioned to AndroidX

@matinzd
Copy link

matinzd commented Aug 25, 2019

Any release on these pull requests?!??!? Last release is for month ago !

@jgtoriginal
Copy link
Contributor Author

jgtoriginal commented Aug 25, 2019 •
edited

I can confirm that following @cipriancaba suggestion on the main project (the one that requires this module) sorts things out. Which puts us in a chicken and an egg situation.
Because if we think that this library should support RN 0.60 out of the box without needing further configurations on the host project in order to work, then this PR should be merged to master, no doubt.
But if we think that there are many users still on RN =< 0.59, merging this would brake their projects and force them to upgrade to RN 0.60 and go for jetify for other modules. Which will eventually happen, maybe not just yet.
Either path seems to be valid, tbh.

@salah-ghanim
Copy link
Collaborator

@jgtoriginal this library should support the latest RN version. users with lower RN versions don't have to update.

@paolorovella
Copy link

paolorovella commented Sep 27, 2019 •
edited

@aurangzaib @jgtoriginal any news on this? react-native released v0.61.1 so i think it's time to merge this PR 🙂

@cormander cormander mentioned this pull request Sep 28, 2019
Closed
syreinrage
syreinrage approved these changes Oct 1, 2019
View reviewed changes
Copy link

@syreinrage syreinrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this resolved my issues with RN 0.60 and AndroidX support library compatibility in my project

@rborn rborn merged commit 801614e into react-native-maps:master Oct 3, 2019
netmaxt3r pushed a commit to netmaxt3r/react-native-maps that referenced this pull request Oct 6, 2019
Merge commit v0.26.1 into eres
2e9fbcd 
* commit '3ae31e4a336102538ee422a0d4e71a2ea32647bb': (24 commits)
  [0.26.1] Release
  rn 0.60.5 support (react-native-maps#3020)
  "AIRMap" was not found in the UIManager IN "0.26.0" (react-native-maps#3103)
  [0.26.0] Release
  Add Heatmap back in (react-native-maps#3064)
  Fixes NPE while removing already removed marker. (react-native-maps#3032)
  Add flat property binding on Marker for iOS (react-native-maps#3051)
  Add heading to the onUserLocationChange listener (react-native-maps#3045)
  Add onDoublePress callback (react-native-maps#2937)
  Allow using onPanDrag while scrollEnabled=true (react-native-maps#2935)
  updating pods for compile error (react-native-maps#3011)
  add overlay onPress event (react-native-maps#3007)
  Fix playServicesVersion name in installation docs (react-native-maps#3016)
  Update index.d.ts (react-native-maps#2887)
  Add @ReactModule annotation to help turbomodules processor (react-native-maps#3001)
  Google Maps - Heatmaps for Android and iOS (react-native-maps#2960)
  Added GeoJSON support by default (react-native-maps#2959)
  Update GoogleMaps pos to 3.2.0 (react-native-maps#2999)
  convert to new react native config format (RN 0.60 (react-native-maps#2975)
  fix select annotation when show/hide callout view (react-native-maps#2973)
  ...

# Conflicts:
#	package.json
yuheidapperapps added a commit to yuheidapperapps/react-native-maps that referenced this pull request Oct 15, 2019
@yuheidapperapps
Merge branch 'master' into fix_crash_for_airmap_reference
6a9eba0 
* master: (31 commits)
  Wider Note column (prevent horisontal scroll) (react-native-maps#3130)
  replaced deprecated bridge.imageLoader calls with moduleForClass API (react-native-maps#3125)
  Implement onUserLocationChange in AIRMap (react-native-maps#2889)
  keep current mapType when taking snapshot (react-native-maps#3120)
  Add mapPadding on iOS maps (react-native-maps#3119)
  [iOS] Expose isAccessibilityElement as a prop (react-native-maps#3115)
  Add supportLibVersion safeguard in gradle build (react-native-maps#3106)
  [0.26.1] Release
  rn 0.60.5 support (react-native-maps#3020)
  "AIRMap" was not found in the UIManager IN "0.26.0" (react-native-maps#3103)
  [0.26.0] Release
  Add Heatmap back in (react-native-maps#3064)
  Fixes NPE while removing already removed marker. (react-native-maps#3032)
  Add flat property binding on Marker for iOS (react-native-maps#3051)
  Add heading to the onUserLocationChange listener (react-native-maps#3045)
  Add onDoublePress callback (react-native-maps#2937)
  Allow using onPanDrag while scrollEnabled=true (react-native-maps#2935)
  updating pods for compile error (react-native-maps#3011)
  add overlay onPress event (react-native-maps#3007)
  Fix playServicesVersion name in installation docs (react-native-maps#3016)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syreinrage syreinrage syreinrage approved these changes

@paolorovella paolorovella paolorovella approved these changes

@AurangzaibRamzan AurangzaibRamzan AurangzaibRamzan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jgtoriginal @DavidPineda @cipriancaba @matinzd @salah-ghanim @paolorovella @syreinrage @AurangzaibRamzan @rborn