Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert to new react native config format (RN 0.60 #2975

Merged

Conversation

adhinugraha
Copy link
Contributor

@adhinugraha adhinugraha commented Jul 24, 2019

Does any other open PR do the same thing?

NO

What issue is this PR fixing?

remove "rnpm": {} in package.json
moving the config into new file "react-native.config.js"

How did you test this PR?

  • Tested on real device & simulator

@andersryanc andersryanc mentioned this pull request Jul 25, 2019
@rahul100885
Copy link

I was looking into this pull request since we have upgraded to react native 0.61.0 and map was failing. I have tried this pull request and found it is working perfectly for iOS but not android it failing with,

Invariant Violation: requireNativeComponent: "AIRMap" was not found in the UIManager.

Now pull request is merged in v0.26, but am still facing the same issue. Does anything is missed by me?

netmaxt3r pushed a commit to netmaxt3r/react-native-maps that referenced this pull request Oct 6, 2019
* commit '3ae31e4a336102538ee422a0d4e71a2ea32647bb': (24 commits)
  [0.26.1] Release
  rn 0.60.5 support (react-native-maps#3020)
  "AIRMap" was not found in the UIManager IN "0.26.0" (react-native-maps#3103)
  [0.26.0] Release
  Add Heatmap back in (react-native-maps#3064)
  Fixes NPE while removing already removed marker. (react-native-maps#3032)
  Add flat property binding on Marker for iOS (react-native-maps#3051)
  Add heading to the onUserLocationChange listener (react-native-maps#3045)
  Add onDoublePress callback (react-native-maps#2937)
  Allow using onPanDrag while scrollEnabled=true (react-native-maps#2935)
  updating pods for compile error (react-native-maps#3011)
  add overlay onPress event (react-native-maps#3007)
  Fix playServicesVersion name in installation docs (react-native-maps#3016)
  Update index.d.ts (react-native-maps#2887)
  Add @ReactModule annotation to help turbomodules processor (react-native-maps#3001)
  Google Maps - Heatmaps for Android and iOS (react-native-maps#2960)
  Added GeoJSON support by default (react-native-maps#2959)
  Update GoogleMaps pos to 3.2.0 (react-native-maps#2999)
  convert to new react native config format (RN 0.60 (react-native-maps#2975)
  fix select annotation when show/hide callout view (react-native-maps#2973)
  ...

# Conflicts:
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants