-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MenuViewManager.mm #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
any idea when we can expect a release? 🙌🏾 |
@JClackett released in v1.0.2 🚀 |
Hmm yeah I've been trying this but still getting this in 1.0.2:
|
Same issue here still on latest version. (node_modules/@react-native-menu/menu/ios/MenuViewManager.mm:10:9)
8 | #else
9 | // OLD ARCH
> 10 | #import <react_native_menu/react_native_menu-Swift.h>
| ^ 'react_native_menu/react_native_menu-Swift.h' file not found
11 | #endif
12 | |
It is a bit odd that although this fixed my iOS build issues, the |
Still exists for me |
@JuanRdBO seems to be fixed in 1.0.3 |
Sadly this still happens to me on 1.0.3 :-/ |
Yup same here |
1.0.2 included this fix and 1.0.3 went back to #import <react_native_menu-Swift.h> But the convention is #import <react_native_menu/react_native_menu-Swift.h> Could you confirm this works and it would then be good to revert the change @svbutko |
@JustJoostNL @JuanRdBO Does it work if you downgrade to 1.0.2, |
It works with 1.0.2! I think we should revert the change |
1.0.3 is working now |
@Gregoirevda the problem is that one change works in NEW ARCH but breaks OLD ARCH and vice versa, this should be addressed differently |
Fixes #751