Replies: 2 comments 14 replies
-
Hi Andra! :) |
Beta Was this translation helpful? Give feedback.
3 replies
-
Yes i even tried to run it directly from node_modules
… Are you sure you're using the right version of TS? (meaning the one
included in the project:
https://github.com/react-native-modal/react-native-modal/blob/d0bf96bfe84f2227820b9d8086a79e0781c0c385/package.json#L78
)
—
Reply to this email directly, view it on GitHub
<#668 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGHNA337K5DFKBJW44MYFFTVIDLPLANCNFSM5UZVICZQ>
.
You are receiving this because you authored the thread.Message ID:
<react-native-modal/react-native-modal/repo-discussions/668/comments/2678519
@github.com>
|
Beta Was this translation helpful? Give feedback.
11 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi everyone!This would be my first contribution to a community package and i'm having trouble to understand the workflow which would lead to a pull request. I forked the repository, then cloned it in a folder inside my project where i'd like to test the changes i will make. Once cloned i do a
npm install
inside the forked repo and thennpm run build
. The problem is that during the build i get lots oferror TS1005: ';' expected
anderror TS1005: '=' expected
. My plan if the build had success would have been to make changes in the .ts files, build again through build command and so on until i commit. Have i understand correctly the process?if not could you point out where i misunderstood?thx in advanceBeta Was this translation helpful? Give feedback.
All reactions