fix: internetReachability aborts handle cancel correctly (#700)

InternetReachability aborts pending request by calling abort() of AbortController. According to AbortController API when abort() is called, the fetch() promise rejects with an Error of type DOMException, with name AbortError. So reject('canceled') will be ignored and checking error !== 'canceled' is useless.

The right way is to use abort('canceled') to set reject reason to 'canceled' instead of DOMException.

Previously because of that InternetReachability aborts previous request and calls _setIsInternetReachable(false).

src/internal/internetReachability.ts

@@ -79,26 +79,19 @@ export default class InternetReachability {
 
     // Create promise that will reject after the request timeout has been reached
     let timeoutHandle: ReturnType<typeof setTimeout>;
-    const timeoutPromise = new Promise<Response>(
-      (_, reject): void => {
-        timeoutHandle = setTimeout((): void => {
-          controller.abort();
-          reject('timedout');
-        }, this._configuration.reachabilityRequestTimeout);
-      },
-    );
+    const timeoutPromise = new Promise<Response>((): void => {
+      timeoutHandle = setTimeout(
+        (): void => controller.abort('timedout'),
+        this._configuration.reachabilityRequestTimeout,
+      );
+    });
 
     // Create promise that makes it possible to cancel a pending request through a reject
     // eslint-disable-next-line @typescript-eslint/no-empty-function
     let cancel: () => void = (): void => {};
-    const cancelPromise = new Promise<Response>(
-      (_, reject): void => {
-        cancel = (): void => {
-          controller.abort();
-          reject('canceled');
-        };
-      },
-    );
+    const cancelPromise = new Promise<Response>((): void => {
+      cancel = (): void => controller.abort('canceled');
+    });
 
     const promise = Promise.race([
       responsePromise,