Android removeListeners implementation incorrect

[mikehardy]

I think count is the number of listeners to remove, so we need to track the number of listener and if the number of listeners is 0 then hasListener should be false

Originally posted by @Legion2 in #548 (comment)

[mikehardy]

I think you are correct - https://github.com/facebook/react-native/blob/4f1f42b0761bff7a68c85cae6de0c4c58c5031d5/Libraries/EventEmitter/NativeEventEmitter.js#L105

So it looks current code will be correct for the case where no listener has been added ever, or when listener count is > 0, but if listeners have been added and removed such that there should no longer be listeners, this will never work without counting and decrementing.

I won't have time to repair this but if you can post a PR I can certainly merge it - thanks for noting it at minimum so that it is tracked now

[Legion2]

I created #569

[matt-oakes]

🎉 This issue has been resolved in version 7.1.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀