Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mac Catalyst #415

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Support Mac Catalyst #415

merged 2 commits into from
Nov 23, 2020

Conversation

kyle-ssg
Copy link
Contributor

The way that telephony was imported broke builds for catalyst, this imports the 2/4 specific files that are used in CoreTelephony.

Fix import of CoreTelephony for OSX
@kyle-ssg kyle-ssg mentioned this pull request Sep 30, 2020
ios/RNCNetInfo.m Outdated Show resolved Hide resolved
Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in principle, @kyle-ssg did you confirm this still works on iOS after the change?

Co-authored-by: Mike Hardy <github@mikehardy.net>
@kyle-ssg
Copy link
Contributor Author

I'll do that later today @mikehardy! Though I believe it will be fine, definitely compiles.

@exotexot
Copy link

please merge this :)

@matt-oakes matt-oakes merged commit 5771efb into react-native-netinfo:master Nov 23, 2020
react-native-community-bot pushed a commit that referenced this pull request Nov 23, 2020
## [5.9.9](v5.9.8...v5.9.9) (2020-11-23)

### Bug Fixes

* **ios:** Support Mac Catalyst ([#415](#415) by [@kyle-ssg](https://github.com/kyle-ssg)) ([5771efb](5771efb))
@react-native-community-bot
Copy link
Collaborator

🎉 This PR is included in version 5.9.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants