Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Checking window before accessing #646

Merged
merged 9 commits into from
Nov 28, 2022
Merged

[Web] Checking window before accessing #646

merged 9 commits into from
Nov 28, 2022

Commits on Nov 28, 2022

  1. check if window object exists in web before trying to avoid accessing… 

    … properties of undefined
    @bombillazo
    bombillazo committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    e61d85d View commit details
    Browse the repository at this point in the history

  2. rename boolean value to hasWindow

    @bombillazo
    bombillazo committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    b02409b View commit details
    Browse the repository at this point in the history

  3. Update src/internal/nativeModule.web.ts 

    Co-authored-by: Mike Hardy <github@mikehardy.net>
    @bombillazo @mikehardy
    bombillazo and mikehardy committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1ac2d25 View commit details
    Browse the repository at this point in the history

  4. Update src/internal/nativeModule.web.ts 

    Co-authored-by: Mike Hardy <github@mikehardy.net>
    @bombillazo @mikehardy
    bombillazo and mikehardy committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    9710268 View commit details
    Browse the repository at this point in the history

  5. Update src/internal/nativeModule.web.ts 

    Co-authored-by: Mike Hardy <github@mikehardy.net>
    @bombillazo @mikehardy
    bombillazo and mikehardy committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    2beed29 View commit details
    Browse the repository at this point in the history

  6. Update src/internal/nativeModule.web.ts 

    Co-authored-by: Mike Hardy <github@mikehardy.net>
    @bombillazo @mikehardy
    bombillazo and mikehardy committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    89653a3 View commit details
    Browse the repository at this point in the history

  7. Update src/internal/nativeModule.web.ts 

    Co-authored-by: Mike Hardy <github@mikehardy.net>
    @bombillazo @mikehardy
    bombillazo and mikehardy committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    55acb66 View commit details
    Browse the repository at this point in the history

  8. revert to explicitly check if window is not undefined

    @bombillazo
    bombillazo committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    e0ab775 View commit details
    Browse the repository at this point in the history

  9. Update src/internal/nativeModule.web.ts 

    Co-authored-by: Mike Hardy <github@mikehardy.net>
    @bombillazo @mikehardy
    bombillazo and mikehardy committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    84a2cc9 View commit details
    Browse the repository at this point in the history