feat(android): 🌟 add support for React Native 0.73

[peterlazar1993]

Overview

Starting from React Native v0.73 , all libraries will need to be updated with namespace due to the upgrade to AGP 8
react-native-community/discussions-and-proposals#671

OS	Implemented
iOS	❌
Android	✅

Test Plan

I tested the changes on RN 0.71.11 and everything works!

[mikehardy]

Hi there! Thanks for posting this as a suggestion, part of it is a strict requirement for rn73 yes, but part of it also specifically cuts off support for users on rn < 70, see this: react-native-community/discussions-and-proposals#671 (comment)

I propose to follow that comment - I'm going to pull this locally and leave AndroidManifest.xml alone so that rn<70 works, but leave the build.gradle change so >=73 works

[mikehardy]

now it is a forwards and backwards compatible change

Yes, users on 71+ will see a warning they can ignore, but that's better than a breaking change

[matt-oakes]

🎉 This PR is included in version 9.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[AlexanderEggers]

Random comment, you could have also defined something like this:

def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION
// Check AGP version for backward compatibility reasons
if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
   namespace = "com.reactnativecommunity.netinfo"
}

[mikehardy]

PRs happily accepted :-)

[AlexanderEggers]

sure, one moment :)

[mikehardy]

on second thought, adding the namespace to build.gradle doesn't create any problems for people that don't care about it (so conditionally adding it is...not interesting?) - it's the inability to remove it from AndroidManifest without triggering a breaking change that's the issue, isn't it?

[AlexanderEggers]

I understood that this would cause build issues on Gradle 6 or older. I have seen a number of packages adopting the above change instead of just adding "namespace" to the gradle file.