Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Static linking #207

Conversation

netmaxt3r
Copy link
Contributor

@netmaxt3r netmaxt3r commented Mar 31, 2021

allow static linking of cocoapod
fix for #204

@martintreurnicht
Copy link
Contributor

@netmaxt3r Thanks for the PR, before i merge this. Have you looked into specifying pod_target_xcconfig = { "DEFINES_MODULE" => "YES" } in podspec instead? Might make usage simpler

@netmaxt3r
Copy link
Contributor Author

@martintreurnicht that patch will go in React-RCTText from react-native , if core team accept that changes no changes required in Podfile while installation.

@martintreurnicht
Copy link
Contributor

@martintreurnicht that patch will go in React-RCTText from react-native , if core team accept that changes no changes required in Podfile while installation.

Ah right, this is on RCTText. Ok i think this is fine, let's merge this

@martintreurnicht martintreurnicht merged commit eab41bc into react-native-text-input-mask:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants