Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use prettier by default #5

Closed
wants to merge 1 commit into from
Closed

Conversation

vonovak
Copy link

@vonovak vonovak commented Feb 2, 2020

Summary

I removed "requirePragma": true from prettierrc because that option means prettier is not enabled unless explicitly turned on using the @format pragma.

in the future this means the pragma comments are not needed

Test Plan

  • eslint passes (it does locally :) )

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@@ -25,13 +25,6 @@
"test:jest": "jest",
"test:tsc":"tsc --noEmit"
},
"prettier": {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettierrc is used so I removed this

@vonovak
Copy link
Author

vonovak commented Feb 2, 2020

not sure why CI is not passing, seems unrelated..?

Copy link
Collaborator

@connectdotz connectdotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @vonovak, thanks for the PR.

I looked at the ci build and it failed actually during the installation: Checkout Example (RN61) because this PR removed the react-native-community-toolbar-android-0.1.0-rc.1.tgz file, which the example used. You can restore that file or find another way for the example to reference the current src without requiring complex setting change that will be great too.

This also surfaced another bug that the ci config should have failed at the linux-checkout job but didn't... Bonus if you can fix this too 🙏

@vonovak vonovak closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants