android,ios: don't reject promise for getStats (#1541)

react-native-webrtc · Apr 10, 2024 · 5d85486 · 5d85486
1 parent a5112e1
commit 5d85486
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 11 deletions.
diff --git a/android/src/main/java/com/oney/WebRTCModule/PeerConnectionObserver.java b/android/src/main/java/com/oney/WebRTCModule/PeerConnectionObserver.java
@@ -255,9 +255,9 @@ public void receiverGetStats(String receiverId, Promise promise) {
 
     public void senderGetStats(String senderId, Promise promise) {
         RtpSender targetSender = null;
-        for (RtpSender r : peerConnection.getSenders()) {
-            if (r.id().equals(senderId)) {
-                targetSender = r;
+        for (RtpSender s : peerConnection.getSenders()) {
+            if (s.id().equals(senderId)) {
+                targetSender = s;
                 break;
             }
         }

diff --git a/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java b/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java
@@ -1245,7 +1245,7 @@ public void receiverGetStats(int pcId, String receiverId, Promise promise) {
             PeerConnectionObserver pco = mPeerConnectionObservers.get(pcId);
             if (pco == null || pco.getPeerConnection() == null) {
                 Log.d(TAG, "receiverGetStats() peerConnection is null");
-                promise.reject(new Exception("PeerConnection ID not found"));
+                promise.resolve(StringUtils.statsToJSON(new RTCStatsReport(0, new HashMap<>())));
             } else {
                 pco.receiverGetStats(receiverId, promise);
             }
@@ -1258,7 +1258,7 @@ public void senderGetStats(int pcId, String senderId, Promise promise) {
             PeerConnectionObserver pco = mPeerConnectionObservers.get(pcId);
             if (pco == null || pco.getPeerConnection() == null) {
                 Log.d(TAG, "senderGetStats() peerConnection is null");
-                promise.reject(new Exception("PeerConnection ID not found"));
+                promise.resolve(StringUtils.statsToJSON(new RTCStatsReport(0, new HashMap<>())));
             } else {
                 pco.senderGetStats(senderId, promise);
             }
@@ -1311,7 +1311,7 @@ public void peerConnectionGetStats(int peerConnectionId, Promise promise) {
             PeerConnectionObserver pco = mPeerConnectionObservers.get(peerConnectionId);
             if (pco == null || pco.getPeerConnection() == null) {
                 Log.d(TAG, "peerConnectionGetStats() peerConnection is null");
-                promise.reject(new Exception("PeerConnection ID not found"));
+                promise.resolve(StringUtils.statsToJSON(new RTCStatsReport(0, new HashMap<>())));
             } else {
                 pco.getStats(promise);
             }

diff --git a/ios/RCTWebRTC/WebRTCModule+RTCPeerConnection.m b/ios/RCTWebRTC/WebRTCModule+RTCPeerConnection.m
@@ -354,7 +354,8 @@ @implementation WebRTCModule (RTCPeerConnection)
                   : (RCTPromiseRejectBlock)reject) {
     RTCPeerConnection *peerConnection = self.peerConnections[objectID];
     if (!peerConnection) {
-        reject(@"invalid_id", @"PeerConnection ID not found", nil);
+        RCTLogWarn(@"PeerConnection %@ not found in peerConnectionGetStats()", objectID);
+        resolve(@"[]");
         return;
     }
 
@@ -370,7 +371,8 @@ @implementation WebRTCModule (RTCPeerConnection)
                   : (RCTPromiseRejectBlock)reject) {
     RTCPeerConnection *peerConnection = self.peerConnections[pcId];
     if (!peerConnection) {
-        reject(@"invalid_id", @"PeerConnection ID not found", nil);
+        RCTLogWarn(@"PeerConnection %@ not found in receiverGetStats()", pcId);
+        resolve(@"[]");
         return;
     }
 
@@ -383,7 +385,8 @@ @implementation WebRTCModule (RTCPeerConnection)
     }
 
     if (!receiver) {
-        reject(@"invalid_id", @"Receiver ID not found", nil);
+        RCTLogWarn(@"RTCRtpReceiver %@ not found in receiverGetStats()", receiverId);
+        resolve(@"[]");
         return;
     }
 
@@ -400,7 +403,8 @@ @implementation WebRTCModule (RTCPeerConnection)
                   : (RCTPromiseRejectBlock)reject) {
     RTCPeerConnection *peerConnection = self.peerConnections[pcId];
     if (!peerConnection) {
-        reject(@"invalid_id", @"PeerConnection ID not found", nil);
+        RCTLogWarn(@"PeerConnection %@ not found in senderGetStats()", pcId);
+        resolve(@"[]");
         return;
     }
 
@@ -413,7 +417,8 @@ @implementation WebRTCModule (RTCPeerConnection)
     }
 
     if (!sender) {
-        reject(@"invalid_id", @"Sender ID not found", nil);
+        RCTLogWarn(@"RTCRtpSender %@ not found in senderGetStats()", senderId);
+        resolve(@"[]");
         return;
     }