M111 #1341
M111 #1341
Conversation
|
Would it be possible to get the webrtc libs hosted on maven? |
|
I tried one approach today, will try another this week. I wish ti do that for this release, yeah. |
|
If it's any help, I actually just went through the process of publishing to sonatype (maven central) over here: https://github.com/webrtc-sdk/android Might need separate publications for two jars though? If you can combine it into an aar, that'd work easier. |
|
I managed to push the AAR yesterday evening! I'll be continuing the work here tomorrow, now using the Maven Central build. FTR the build scripts are in the jitsi/webrtc repo. |
saghul
force-pushed
the
M111
branch
2 times, most recently
from
e641105
to
24dd460
Compare
|
@davidliu Updated! I'll do some testing tomorrow. |
|
Added another commit with an API to customize codec factories and a couple of useful ones we have been using with Jitsi Meet. This was on Android. I'll add a similar one for iOS, without the extra factory implementations, since the default one is already doing H.264 in hardware and the rest in software. |
Migrate Android to using the Jitsi WebRTC build now available on Maven Central. The deprecated bitcode downloading scripts have now been removed.
saghul
force-pushed
the
M111
branch
2 times, most recently
from
bf91eb3
to
0d86043
Compare
|
Added iOS initialization options config. |
android/src/main/java/com/oney/WebRTCModule/webrtcutils/SoftwareVideoDecoderFactoryProxy.java
Show resolved
Hide resolved
android/src/main/java/com/oney/WebRTCModule/webrtcutils/SoftwareVideoEncoderFactoryProxy.java
Show resolved
Hide resolved
WebRTCModuleOptions must be instantiated early, before React Native is.
Currently supporting:
- (video) codec factories
- Field trials
- Logging level
The default codec factories use the hardware codecs and fallback to the
software ones if not available.
If simulcast is defired a software encoder must be used. In addition, we
(Jitsi) have seen many crashes with hardware decoders in the past, so we
also resorted to software decoding.
2 types of codec factories are provided for convenience:
- SoftwareVideo{Encoder,Decoder}FactoryProxy: In 111 WebRTC refactored
the software codec factories, which now depend on JNI and thus cannot
be initialized early. These proxy factories delay initialization so
they are easier to work with.
- H264AndSoftwareVideo{Encoder,Decoder}Factory: These are hybrid
factories that use the hardware encoder / decoder for H.264 and the
software codec factories for the rest. These mimic the default iOS
codec factories.
Currently supporting: - (video) codec factories - Field trials - Logging level
|
Testing went fine. I'll likely merge it tomorrow if there are no further comments. |
|
LGTM, will run some tests, loving the customisation changes 👍🏻 |
Thank you! |
Thanks @8BallBomBom ! I don't plan to make the release today, let's have it settle a bit in master :-) |
No description provided.