Quick null check for both ios and android. #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
approved these changes
Mar 20, 2023
|
@8BallBomBom i think this is ready, can you please squash and adjust the commit message when merging? |
|
Ahhhh, not very often i do that but will instead do drafts then squash the lot once ready 👍🏻 |
|
LGTM, please go ahead and merge! |
saghul
approved these changes
Mar 21, 2023
|
Don't think i actually have them permissions 🤔 |
|
@8BallBomBom done for you :) |
|
Saved my bacon, thanks 😅 |
Well, let me fix that then! |
|
Fixed :-) |
|
Thank you 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Won't fix this issue but will make developers aware that they will need to run pod install or npm install as it would appear some linking commands don't always execute properly when adding packages to your project.
Not actually sure if that is intentional or not.
Also would it be worth mentioning anything about alternative package managers like yarn?