add catalyst support to build script #1420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that all that's needed for building the right XCFramework slice? Nice! What webrtc version did this start working on? |
|
I did not test other versions, but it works with the latest version of the webrtc repo |
|
Ok. I'll give it a try when we bump to 114 or 115. |
8BallBomBom
added
enhancement
8BallBomBom
added
confirmed
|
@saghul Possible to be included with the M124 update? |
|
If I need to do another build I'll include it. I forgot about this PR, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1033, chromium's webrtc supports catalyst as a target, which has now been added to the build webrtc script.
Also the ios_deployment_target is set to 14.0 for and only for catalyst targets. (remains 12.0 for ios)