Skip to content

Commit

Permalink
fix(logs): remove warning logs for common/handled error events. (#2043)
Browse files Browse the repository at this point in the history
* remove warning logs for common/handled error events.

* re-add warn logs, but only if not handled

Co-authored-by: Cristiano Coelho <cristianocca@hotmail.com>
  • Loading branch information
cristianoccazinsp and cristianocca committed Jul 1, 2021
1 parent e33eea6 commit 279d6ae
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
5 changes: 4 additions & 1 deletion src/WebView.android.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,16 @@ class WebView extends React.Component<AndroidWebViewProps, State> {
onLoadingError = (event: WebViewErrorEvent) => {
event.persist(); // persist this event because we need to store it
const { onError, onLoadEnd } = this.props;

if (onError) {
onError(event);
} else {
console.warn('Encountered an error loading page', event.nativeEvent);
}

if (onLoadEnd) {
onLoadEnd(event);
}
console.warn('Encountered an error loading page', event.nativeEvent);

this.setState({
lastErrorEvent: event.nativeEvent,
Expand Down
5 changes: 4 additions & 1 deletion src/WebView.ios.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -195,13 +195,16 @@ class WebView extends React.Component<IOSWebViewProps, State> {
onLoadingError = (event: WebViewErrorEvent) => {
event.persist(); // persist this event because we need to store it
const { onError, onLoadEnd } = this.props;

if (onLoadEnd) {
onLoadEnd(event);
}

if (onError) {
onError(event);
} else {
console.warn('Encountered an error loading page', event.nativeEvent);
}
console.warn('Encountered an error loading page', event.nativeEvent);

this.setState({
lastErrorEvent: event.nativeEvent,
Expand Down
5 changes: 4 additions & 1 deletion src/WebView.macos.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,16 @@ class WebView extends React.Component<MacOSWebViewProps, State> {
onLoadingError = (event: WebViewErrorEvent) => {
event.persist(); // persist this event because we need to store it
const { onError, onLoadEnd } = this.props;

if (onLoadEnd) {
onLoadEnd(event);
}

if (onError) {
onError(event);
} else {
console.warn('Encountered an error loading page', event.nativeEvent);
}
console.warn('Encountered an error loading page', event.nativeEvent);

this.setState({
lastErrorEvent: event.nativeEvent,
Expand Down

0 comments on commit 279d6ae

Please sign in to comment.