feat(typescript): Source code rewrite using typescript #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusU
reviewed
Mar 15, 2019
| @@ -42,16 +40,16 @@ const createOnShouldStartLoadWithRequest = ( | |||
| url: string, | |||
| lockIdentifier: number, | |||
| ) => void, | |||
| originWhitelist: ?$ReadOnlyArray<string>, | |||
There was a problem hiding this comment.
TypeScript also has a read-only array: ReadonlyArray<T>
There was a problem hiding this comment.
Well we do have eslint to not modify received parameters, but that's nice to know
There was a problem hiding this comment.
It's nice to use because if users are using readonly variables to enforce mutability, TypeScript won't let them pass those variables to us since it thinks we are going to mutate them.
Basically, it's a way to document the interface 📝
There was a problem hiding this comment.
ok nice I'll make those changes before merging :)
LinusU
approved these changes
Mar 15, 2019
react-native-community-bot
pushed a commit
that referenced
this pull request
Mar 20, 2019
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Awesome work @Titozzz 👏 🚀 |
phuongwd
pushed a commit
to phuongwd/react-native-webview
that referenced
this pull request
Apr 29, 2020
…webview#425) Rewrote the whole repository into typescript. This will provide way better and up to date documentation. This should also add some safety for people contributing 😄 . Flow types were not working until now which is why this PR doesn't have them but feel free to PR. This also fixes react-native-webview#384 react-native-webview#435 react-native-webview#206 react-native-webview#171 react-native-webview#168.
phuongwd
pushed a commit
to phuongwd/react-native-webview
that referenced
this pull request
Apr 29, 2020
# [5.4.0](react-native-webview/react-native-webview@v5.3.1...v5.4.0) (2019-03-20) ### Features * **typescript:** Source code rewrite using typescript ([react-native-webview#425](react-native-webview#425)) ([453b7dd](react-native-webview@453b7dd)), closes [react-native-webview#384](react-native-webview#384) [react-native-webview#435](react-native-webview#435) [react-native-webview#206](react-native-webview#206) [react-native-webview#171](react-native-webview#171) [react-native-webview#168](react-native-webview#168)
noproblem23
added a commit
to noproblem23/react-native-webview
that referenced
this pull request
Apr 18, 2023
# [5.4.0](react-native-webview/react-native-webview@v5.3.1...v5.4.0) (2019-03-20) ### Features * **typescript:** Source code rewrite using typescript ([#425](react-native-webview/react-native-webview#425)) ([453b7dd](react-native-webview/react-native-webview@453b7dd)), closes [#384](react-native-webview/react-native-webview#384) [#435](react-native-webview/react-native-webview#435) [#206](react-native-webview/react-native-webview#206) [#171](react-native-webview/react-native-webview#171) [#168](react-native-webview/react-native-webview#168)
jaynilson
added a commit
to jaynilson/reactNative_service_USA
that referenced
this pull request
Sep 11, 2024
# [5.4.0](react-native-webview/react-native-webview@v5.3.1...v5.4.0) (2019-03-20) ### Features * **typescript:** Source code rewrite using typescript ([#425](react-native-webview/react-native-webview#425)) ([453b7dd](react-native-webview/react-native-webview@453b7dd)), closes [#384](react-native-webview/react-native-webview#384) [#435](react-native-webview/react-native-webview#435) [#206](react-native-webview/react-native-webview#206) [#171](react-native-webview/react-native-webview#171) [#168](react-native-webview/react-native-webview#168)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.