Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that drawer in tabs works with RNGH #7591

Closed
brentvatne opened this issue Sep 26, 2018 · 3 comments
Closed

Verify that drawer in tabs works with RNGH #7591

brentvatne opened this issue Sep 26, 2018 · 3 comments

Comments

@brentvatne
Copy link
Member

This pattern is kind of silly but sure let's I guess make sure it works. #4714

@daviscabral
Copy link

daviscabral commented Sep 27, 2018

This pattern is kind of silly

Indeed.

@brentvatne brentvatne self-assigned this Oct 1, 2018
@evert-smit
Copy link

I can verify that it works, although you might be looking for a PR with a test.

"react": "16.5.1",
"react-native": "0.57.2",
"react-navigation": "^3.0.0-rc.5",
"react-native-gesture-handler": "^1.0.9",

The pattern doesn't have to be that silly: you can use the drawer for other purposes, like filtering/sorting a main view without actually navigating, using a custom drawer component. Which might not be the intended or most obvious use-case of react-navigation, but hey. :)

@brentvatne
Copy link
Member Author

thanks @evert-smit! yeah at some point we should add automated ui tests, i'll maybe look into that after releasing 3.0 proper soon

@satya164 satya164 transferred this issue from react-navigation/drawer Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants