Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: import #595

Closed
wants to merge 2 commits into from
Closed

Fix: import #595

wants to merge 2 commits into from

Conversation

kopax
Copy link

@kopax kopax commented Jan 5, 2020

Imports was broken, it seems that the correct packge is react-navigation-hooes, see https://github.com/react-navigation/native/issues/37

READ ME PLEASE!

TL;DR: Make sure to add your changes to versioned docs

Thanks for opening a PR!

The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. website/versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. 馃憤

Imports was broken, it seems that the correct packge is react-navigation-hooes, see https://github.com/react-navigation/native/issues/37
Imports was broken, it seems that the correct packge is react-navigation-hooes, see https://github.com/react-navigation/native/issues/37
@satya164
Copy link
Member

satya164 commented Jan 5, 2020

The documentation is for React Navigation 5 (next). You're using React Navigation 4. Please read the docs for the stable version at https://reactnavigation.org/

@satya164 satya164 closed this Jan 5, 2020
@kopax
Copy link
Author

kopax commented Jan 5, 2020

Thanks @satya164 for enlightening me, what should I do now? Should I use react-navigation 5? I am just starting and haven't implemented anything that I can't throw.

@kopax kopax deleted the patch-2 branch January 5, 2020 14:50
@satya164
Copy link
Member

satya164 commented Jan 5, 2020

It's upto you if you want to use the stable version or the prerelease version.

@kopax
Copy link
Author

kopax commented Jan 5, 2020

I will rather be on the prerelease version if I can do the same work, but since I have no clue I stick to the last stable release.

Are you working on it? Because I am not. I have no clue if I can use it for production. (features status? API changes (and documentated)? ETA?), maybe you can give me a hint?

@satya164
Copy link
Member

satya164 commented Jan 5, 2020

It's fairly stable with very minor issues. But I see that you need web support which isn't implemented yet.

@kopax
Copy link
Author

kopax commented Jan 5, 2020

Actually, for web I am using react-router. I have started to implement with v4, but I will definitly switch to v5 alpha if you say so. I will study the next documentation, in case you have time to answer this little question, is there an upgrade guide I can follow or is the API for the following the same?

What's is the biggest difference between the two?

I am basically just using createStackNavigator, createSwitchNavigator and createAppContainer,.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants