refactor: rename shifting animation to shift

react-navigation · Mar 8, 2024 · 0e5b108 · 0e5b108
1 parent 41e512e
commit 0e5b108
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/example/src/Screens/BottomTabs.tsx b/example/src/Screens/BottomTabs.tsx
@@ -79,7 +79,7 @@ const AlbumsScreen = () => {
 
 const Tab = createBottomTabNavigator<BottomTabParams>();
 
-const animations = ['none', 'fade', 'shifting'] as const;
+const animations = ['none', 'fade', 'shift'] as const;
 
 export function BottomTabs() {
   const { showActionSheetWithOptions } = useActionSheet();

diff --git a/packages/bottom-tabs/src/TransitionConfigs/SceneStyleInterpolators.tsx b/packages/bottom-tabs/src/TransitionConfigs/SceneStyleInterpolators.tsx
@@ -22,7 +22,7 @@ export function forFade({
 /**
  * Animation where the screens slightly shift to left/right
  */
-export function forShifting({
+export function forShift({
   current,
 }: BottomTabSceneInterpolationProps): BottomTabSceneInterpolatedStyle {
   return {

diff --git a/packages/bottom-tabs/src/TransitionConfigs/TransitionPresets.tsx b/packages/bottom-tabs/src/TransitionConfigs/TransitionPresets.tsx
@@ -1,13 +1,13 @@
 import type { BottomTabTransitionPreset } from '../types';
-import { forFade, forShifting } from './SceneStyleInterpolators';
-import { CrossFadeSpec, ShiftingSpec } from './TransitionSpecs';
+import { forFade, forShift } from './SceneStyleInterpolators';
+import { CrossFadeSpec, ShiftSpec } from './TransitionSpecs';
 
 export const FadeTransition: BottomTabTransitionPreset = {
   transitionSpec: CrossFadeSpec,
   sceneStyleInterpolator: forFade,
 };
 
-export const ShiftingTransition: BottomTabTransitionPreset = {
-  transitionSpec: ShiftingSpec,
-  sceneStyleInterpolator: forShifting,
+export const ShiftTransition: BottomTabTransitionPreset = {
+  transitionSpec: ShiftSpec,
+  sceneStyleInterpolator: forShift,
 };
diff --git a/packages/bottom-tabs/src/TransitionConfigs/TransitionSpecs.tsx b/packages/bottom-tabs/src/TransitionConfigs/TransitionSpecs.tsx
@@ -10,7 +10,7 @@ export const CrossFadeSpec: TransitionSpec = {
   },
 };
 
-export const ShiftingSpec: TransitionSpec = {
+export const ShiftSpec: TransitionSpec = {
   animation: 'timing',
   config: {
     duration: 150,

diff --git a/packages/bottom-tabs/src/types.tsx b/packages/bottom-tabs/src/types.tsx
@@ -85,7 +85,7 @@ export type TabBarVisibilityAnimationConfig =
   | TimingKeyboardAnimationConfig
   | SpringKeyboardAnimationConfig;
 
-export type TabAnimationName = 'none' | 'fade' | 'shifting';
+export type TabAnimationName = 'none' | 'fade' | 'shift';
 
 export type BottomTabNavigationOptions = HeaderOptions & {
   /**
@@ -270,7 +270,7 @@ export type BottomTabNavigationOptions = HeaderOptions & {
    * Supported values:
    * - 'none': don't animate the screen (default)
    * - 'fade': cross-fade the screens.
-   * - 'shifting': shift the screens slightly shift to left/right.
+   * - 'shift': shift the screens slightly shift to left/right.
    */
   animation?: TabAnimationName;
 

diff --git a/packages/bottom-tabs/src/views/BottomTabView.tsx b/packages/bottom-tabs/src/views/BottomTabView.tsx
@@ -14,7 +14,7 @@ import { SafeAreaInsetsContext } from 'react-native-safe-area-context';
 
 import {
   FadeTransition,
-  ShiftingTransition,
+  ShiftTransition,
 } from '../TransitionConfigs/TransitionPresets';
 import type {
   BottomTabBarProps,
@@ -44,7 +44,7 @@ const STATE_ON_TOP = 2;
 
 const NAMED_TRANSITIONS_PRESETS = {
   fade: FadeTransition,
-  shifting: ShiftingTransition,
+  shift: ShiftTransition,
   none: {
     sceneStyleInterpolator: undefined,
     transitionSpec: {