Skip to content

Commit

Permalink
chore: remove detox references (#10661)
Browse files Browse the repository at this point in the history
Clean-up PR removing references to detox as react-navigation repo doesn't use the detox package for e2e tests anymore.

- removed detox config from package.json
- updated CONTRUBUTING.md to use playwright in place of detox
  • Loading branch information
kacperkapusciak authored and satya164 committed Nov 27, 2022
1 parent 7f01efd commit 5aa59b8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 32 deletions.
18 changes: 8 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,24 +45,22 @@ Remember to add tests for your change if possible. Run the unit tests by:
yarn test
```

Running the e2e tests with Detox (on iOS) requires the following:
Running the e2e tests with Playwright requires building the [example app](/example/) for web:

- Mac with macOS (at least macOS High Sierra 10.13.6)
- Xcode 10.1+ with Xcode command line tools
```sh
yarn example expo build:web --no-pwa
```

First you need to install `applesimutils` and `detox-cli`:
Before running tests configure Playwright with:

```sh
brew tap wix/brew
brew install applesimutils
yarn global add detox-cli
yarn playwright install
```

Then you can build and run the tests:
Run the e2e tests by:

```sh
detox build -c ios.sim.debug
detox test -c ios.sim.debug
yarn example test:e2e
```

### Commit message convention
Expand Down
22 changes: 0 additions & 22 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,27 +76,5 @@
"useTabs": false,
"singleQuote": true,
"trailingComma": "es5"
},
"detox": {
"test-runner": "jest",
"runner-config": "example/e2e/config.json",
"configurations": {
"ios.sim.debug": {
"binaryPath": "example/ios/build/Build/Products/Debug-iphonesimulator/ReactNavigationExample.app",
"build": "set -o pipefail; xcodebuild -workspace example/ios/ReactNavigationExample.xcworkspace -scheme ReactNavigationExample -configuration Debug -sdk iphonesimulator -derivedDataPath example/ios/build",
"type": "ios.simulator",
"device": {
"type": "iPhone 11 Pro"
}
},
"ios.sim.release": {
"binaryPath": "example/ios/build/Build/Products/Release-iphonesimulator/ReactNavigationExample.app",
"build": "export RCT_NO_LAUNCH_PACKAGER=true; set -o pipefail; xcodebuild -workspace example/ios/ReactNavigationExample.xcworkspace -scheme ReactNavigationExample -configuration Release -sdk iphonesimulator -derivedDataPath example/ios/build",
"type": "ios.simulator",
"device": {
"type": "iPhone 11 Pro"
}
}
}
}
}

0 comments on commit 5aa59b8

Please sign in to comment.