Skip to content

Commit

Permalink
fix: preserve params when switching tabs. fixes #9782
Browse files Browse the repository at this point in the history
  • Loading branch information
satya164 committed Aug 3, 2021
1 parent be8532c commit 98fa233
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/bottom-tabs/src/views/BottomTabBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ export default function BottomTabBar({

if (!focused && !event.defaultPrevented) {
navigation.dispatch({
...CommonActions.navigate(route.name),
...CommonActions.navigate({ name: route.name, merge: true }),
target: state.key,
});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/drawer/src/views/DrawerItemList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default function DrawerItemList({
navigation.dispatch({
...(focused
? DrawerActions.closeDrawer()
: CommonActions.navigate(route.name)),
: CommonActions.navigate({ name: route.name, merge: true })),
target: state.key,
});
}}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { SafeAreaProviderCompat } from '@react-navigation/elements';
import {
CommonActions,
Link,
ParamListBase,
Route,
TabActions,
TabNavigationState,
useLinkBuilder,
useTheme,
Expand Down Expand Up @@ -106,7 +106,10 @@ function MaterialBottomTabViewInner({
navigationState={state}
onIndexChange={(index: number) =>
navigation.dispatch({
...TabActions.jumpTo(state.routes[index].name),
...CommonActions.navigate({
name: state.routes[index].name,
merge: true,
}),
target: state.key,
})
}
Expand Down
7 changes: 5 additions & 2 deletions packages/material-top-tabs/src/views/MaterialTopTabView.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {
CommonActions,
ParamListBase,
Route,
TabActions,
TabNavigationState,
useTheme,
} from '@react-navigation/native';
Expand Down Expand Up @@ -48,7 +48,10 @@ export default function MaterialTopTabView({
{...rest}
onIndexChange={(index) =>
navigation.dispatch({
...TabActions.jumpTo(state.routes[index].name),
...CommonActions.navigate({
name: state.routes[index].name,
merge: true,
}),
target: state.key,
})
}
Expand Down

0 comments on commit 98fa233

Please sign in to comment.