avoid unnecessary navigation completion dispatches

react-navigation · Apr 4, 2018 · d2fe180 · d2fe180
1 parent d57d118
commit d2fe180
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/src/views/StackView/StackView.js b/src/views/StackView/StackView.js
@@ -25,14 +25,19 @@ class StackView extends React.Component {
         navigation={this.props.navigation}
         descriptors={this.props.descriptors}
         onTransitionStart={this.props.onTransitionStart}
-        onTransitionEnd={(lastTransition, transition) => {
+        onTransitionEnd={(transition, lastTransition) => {
           const { onTransitionEnd, navigation } = this.props;
-          navigation.dispatch(
-            StackActions.completeTransition({
-              key: navigation.state.key,
-            })
-          );
-          onTransitionEnd && onTransitionEnd(lastTransition, transition);
+          if (
+            transition.navigation.state.isTransitioning &&
+            !lastTransition.navigation.state.isTransitioning
+          ) {
+            navigation.dispatch(
+              StackActions.completeTransition({
+                key: navigation.state.key,
+              })
+            );
+          }
+          onTransitionEnd && onTransitionEnd(transition, lastTransition);
         }}
       />
     );