fix: fix type error when passing unannotated navigation ref

react-navigation · May 14, 2021 · dc4ffc0 · dc4ffc0
1 parent 9c30c42
commit dc4ffc0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/example/src/index.tsx b/example/src/index.tsx
@@ -206,7 +206,7 @@ export default function App() {
     return () => Dimensions.removeEventListener('change', onDimensionsChange);
   }, []);
 
-  const navigationRef = useNavigationContainerRef<RootStackParamList>();
+  const navigationRef = useNavigationContainerRef();
 
   useReduxDevToolsExtension(navigationRef);
 

diff --git a/packages/core/src/useNavigationContainerRef.tsx b/packages/core/src/useNavigationContainerRef.tsx
@@ -1,10 +1,9 @@
 import * as React from 'react';
-import type { ParamListBase } from '@react-navigation/routers';
 import createNavigationContainerRef from './createNavigationContainerRef';
 import type { NavigationContainerRefWithCurrent } from './types';
 
 export default function useNavigationContainerRef<
-  ParamList extends ParamListBase
+  ParamList extends {} = ReactNavigation.RootParamList
 >(): NavigationContainerRefWithCurrent<ParamList> {
   const navigation = React.useRef<NavigationContainerRefWithCurrent<ParamList> | null>(
     null

diff --git a/packages/devtools/src/useReduxDevToolsExtension.tsx b/packages/devtools/src/useReduxDevToolsExtension.tsx
@@ -3,7 +3,6 @@ import type {
   NavigationContainerRef,
   NavigationState,
   NavigationAction,
-  ParamListBase,
 } from '@react-navigation/core';
 import deepEqual from 'deep-equal';
 
@@ -23,7 +22,7 @@ type DevToolsExtension = {
 declare const __REDUX_DEVTOOLS_EXTENSION__: DevToolsExtension | undefined;
 
 export default function useReduxDevToolsExtension(
-  ref: React.RefObject<NavigationContainerRef<ParamListBase>>
+  ref: React.RefObject<NavigationContainerRef<any>>
 ) {
   const devToolsRef = React.useRef<DevToolsConnection>();