-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to show tabs on the side #11578
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11578 +/- ##
==========================================
- Coverage 75.77% 75.59% -0.19%
==========================================
Files 200 201 +1
Lines 5817 5859 +42
Branches 2271 2306 +35
==========================================
+ Hits 4408 4429 +21
- Misses 1362 1378 +16
- Partials 47 52 +5
☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The Expo app for the example from this branch is ready! |
c3c4a9b
to
f93311c
Compare
f93311c
to
93a4ec0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code works and looks good in general. One question is if the name "bottom-tab" is still valid?
You could make the argument is that the default one is still bottom, and you could position tabs at the top in material-top-tabs so it's like this already 😅 But yeah, the only real argument I have is to avoid another big breaking change (especially to keep older blog posts, examples etc. working) and to keep our download counts on npm. |
Motivation
This adds ability to render the tab bar on left/right as a sidebar. It useful on larger screens where we may want to take advantage of the available horizontal screen and show a sidebar instead of a bottom tab bar.
Test plan
Open the "Bottom Tabs" example and resize the screen to see the different modes of the tab bar. Tap on the "<<" button on the bottom left to switch between a smaller and larger sidebar.
Video
RPReplay_Final1694275006.mp4