fix: follow-up for the retain-related changes in stack router #11768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11768 +/- ##
==========================================
- Coverage 76.74% 76.73% -0.01%
==========================================
Files 207 207
Lines 6101 6103 +2
Branches 2384 2385 +1
==========================================
+ Hits 4682 4683 +1
- Misses 1367 1368 +1
Partials 52 52 ☔ View full report in Codecov by Sentry. |
|
The Expo app for the example from this branch is ready! |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
satya164
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request.
Motivation
Explain the motivation for making this change. What existing problem does the pull request solve?
If this pull request addresses an existing issue, link to the issue. If an issue is not present, describe the issue here.
Test plan
Describe the steps to test this change so that a reviewer can verify it. Provide screenshots or videos if the change affects UI.
The change must pass lint, typescript and tests.