Remove 1.5x back-icon.png images. Ensures the back icon renders in iOS production builds, fixes #11792 #12019
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sparkertime! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for the PR. Isn't this a bug in Expo's bundler that should be fixed? Have you opened a bug report there? |
As I mentioned, I'm a React Native dunce so I have no idea and it's a bit beyond my capabilities to find out. Feel free to close this if this is the wrong solution and thanks for the quick response! |
|
@sparkertime I'll merge the PR, however I'd also request to open an issue in Expo regarding this. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request.
Motivation
I've been seeing the issue described by #11792 where the back button is not shown on iOS. It's a frustrating problem since the issue – back buttons on a Stack Navigator not showing on iOS – only happens in production builds.
Test plan
I ported the React Native code for
renderBackImageinHeaderBackButtonalong with all assets and used that as a starting point to troubleshoot the issue. Removing the1.5xvariants fixes the problem for me. I'm enough of a React Native dunce that I don't totally understand why those two files cause issues, but removing those files seems fine since that scale doesn't seem to be supported anyway according to the Image docs.I'd submit a test plan but as the others have reported in the issue linked above, this is a production-only bug for me.