Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Contribution Guide / Submitting / New views -> Incomplete #49

Closed
elliottjro opened this issue Jan 27, 2017 · 3 comments
Closed

Docs: Contribution Guide / Submitting / New views -> Incomplete #49

elliottjro opened this issue Jan 27, 2017 · 3 comments

Comments

@elliottjro
Copy link

New views or unique features

Often navigation needs are specific to certain apps. If your changes are unique to your app, you may want to fork the view or router that has changed. You can keep the source code in your app, or publish it on npm as a react-navigation compatible view or router.
This library is intended to include highly standard and generic navigation patterns. But it

It looks like the New views section is incomplete and just ends at the noted bolded section

@ericvicenti
Copy link
Contributor

Whoops! This is meant to encourage people to publish their own view libraries that can use navigation state and integrate seamlessly. The same can be done with routers, so that custom routers can contain React Nav routers, or be contained by them.

I think that the most generic views should live in the core library, but everything else can be published as independent modules.

It would be awesome if you or anybody else could revise this section to reflect this.

@elliottjro
Copy link
Author

I will need help with this revision as I am just getting into navigation states.

@elliottjro
Copy link
Author

elliottjro commented Feb 14, 2017

fixed ish in #280 and continued in #247

ShyJuno pushed a commit to ShyJuno/react-navigation that referenced this issue Apr 19, 2024
…create-context

Remove create-react-context to shrink bundle size impact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants